search

JeffersonLab / hps-mc

HPS MC toolkit
1 stars 6 forks source link

Job params integration #334

Closed sarahgaiser closed 1 year ago

sarahgaiser commented 1 year ago

Cam and I came to the conclusion that it's best if we get rid of RunParameters and move the parameters that are set by this class to the job.json configurations. I implemented this change, including renaming target_z from the run_params to target_thickness so that it does not get confused with target_z from the job config which is the target z position. I had to adjust most examples and prod configs to account for these changes. In addition to that I adjusted the unit tests according to the changes.

JeremyMcCormick commented 1 year ago

Can you switch this to a branch on the main repository. please? There is no good reason to be using a fork.