JeffersonLab / hps-mc

HPS MC toolkit
1 stars 6 forks source link

Examples should by default run in a local environment #360

Closed JeremyMcCormick closed 1 year ago

JeremyMcCormick commented 1 year ago

Many of the examples have scripts that assume the user is running in Slurm. This is fine for production at a specific site, but examples should generally assume local development. Or the scripts should be clearly named like run_slurm.sh or run_local.sh. Most (all?) of the examples seem to be setup this way now.

The dev toolkit setup should also not be hard-coded into script the script like this:

#!/usr/bin/scl enable devtoolset-8 -- /bin/bash

Any example that is actually be used for production should be migrated to a directory under prod.

JeremyMcCormick commented 1 year ago

I believe this is largely fixed now, as most of the examples run locally and use http input files.

There are some batch system examples specific to SLAC, but that's fine.