this is necessary because the 2016 parameter mapping had a few typos in it when making the assignments which breaks the translation from ID number to layer number and Ax/St
To Do
[x] Format according to pycodestyle
[x] Update function documentation
[x] Check how this affects results when reading res file (and no mapping is available)
What Did I Do??
Because the 2016 parameter mapping does not follow the convention set by the later 2019+ mapping allowing for simple arithmetic to calculate the layer number from the last two digits of the ID, I have switched the layer-number-deduction to simply extract it from the parameter name as it appears in the mapping. Similarly, I switched to deducing axial/stereo by looking for those words in the name rather than trying to deduce it from the ID.
Besides this necessary change, I also added a few more cosmetic updates.
Add a new line when writing a note to a detector README to keep the notes spaced out.
Convert all directory variables passed on the command line to batch.py into absolute paths and create them if necessary.
Convert the run directory to absolute path in job.py
Patch a bug in pede_job.py which switched the no_copy decision accidentally.
Make sure any updated detector is installed rather than just built by adding install to hps-mc-construct-detector
this is necessary because the 2016 parameter mapping had a few typos in it when making the assignments which breaks the translation from ID number to layer number and Ax/St
To Do
resfile (and no mapping is available)What Did I Do??
Because the 2016 parameter mapping does not follow the convention set by the later 2019+ mapping allowing for simple arithmetic to calculate the layer number from the last two digits of the ID, I have switched the layer-number-deduction to simply extract it from the parameter name as it appears in the mapping. Similarly, I switched to deducing axial/stereo by looking for those words in the name rather than trying to deduce it from the ID.
Besides this necessary change, I also added a few more cosmetic updates.
batch.pyinto absolute paths and create them if necessary.job.pypede_job.pywhich switched theno_copydecision accidentally.installtohps-mc-construct-detector