JeffersonLab / hpstr

Heavy Photon Search Toolkit for Reconstruction
2 stars 18 forks source link

Rorys hpstr #169

Closed rodwyer100 closed 1 year ago

rodwyer100 commented 1 year ago

Pushing in the desired changes from Cam into the current branch. Made rawSvtAna_cfg.py changes to reflect the names of new regions I am using. I may include new config files should Cam think it appropriate for this commit. The name removal thing (to optionally not include hits in your fsp) is as of yet invalidated. Will check now.

rodwyer100 commented 1 year ago

Validation Task:

I first run a default fsp processor on a collection of reconstructed events from 14552 (I already run data_cnv jobs on them for another task) and obtain the following output with options.rawHits=1: image

When I run with -r = 0 or options.rawHits=0 I obtain the following output: image

This is consistent with what we desired: it does remove the names of collections in fsp relevant to keeping hits

This produced two output root files, one clearly missing the Hit collections: image

So far it is passing validation testing with flying colors. One thing in TBrowser is that when I click on distributions in FSP which should be populated they are not plotted on TBrowser. There are alot of reasons this can occur which should not cause any concern, but I will fish around a little longer.

rodwyer100 commented 1 year ago

Because I am a world class dingus, I forgot this was applied to slcio files :). Runnign on them with the same theme (also including header in fsp) I get the following: image

Even in the collection without hits, track information is indeed now populated: image

Everything seems kosher now.

bloodyyugo commented 1 year ago

I assume this works the same if we include the full list of Si clusters and raw hits instead of just the hits-on-track. True?

rodwyer100 commented 1 year ago

Sorry Matt let me reply to Cam first: he asked me to do something beefy and it took me awhile. Namely he wanted me to validate that when I remove raw htis and keep the hits on track I can still acess the hits on track. I can. Here are their times: image

rodwyer100 commented 1 year ago

Sorry Matt maybe I just answered your question as well? It should if I understand your meaning correctly. Thats just including all the relevant info. You can the raw hits and other stuff for analysis optionally

rodwyer100 commented 1 year ago

I think you would need to include track hits in any case because you need them to refer to raw hits (as they are contained as a property of them and are linked by a TRefArray).

cbravo135 commented 1 year ago

@bloodyyugo The Ntuples are configurable to keep what you want. If you want to include all the raw hits, there is a different processor that already exists that you should use, and same with Si clusters. This processor will include the hits and/or raw hits (configurable) associated to the particle tracks.

rodwyer100 commented 1 year ago

Added all of my config files for rawSvtHitAnaProcessor. Should be able to run now.