search

JeffersonLab / iguana

Preservation of common physics data analysis algorithms. Currently focused on HIPO data.
https://jeffersonlab.github.io/iguana/
GNU Lesser General Public License v3.0
2 stars 7 forks source link

ZVertexFilter: Added option for pids and validator #242

Closed rtysonCLAS12 closed 3 months ago

rtysonCLAS12 commented 3 months ago

Simple fix to add pids of particles for which to filter based on zvertex. Added default to only electrons in Config.yaml.

Also added validator to plot before and after zvertex cuts. This is plotted for electrons, on which we cut in the validator, but also other particles which shouldn't (and aren't) cut on.

Example plots for electrons and pions outputted by validator: image image

rtysonCLAS12 commented 3 months ago

Thanks Chris for fixing the example files and fortran bindings, I had missed those in the original commit

rtysonCLAS12 commented 3 months ago

@c-dilks I've added the changes you recommended

c-dilks commented 3 months ago

Looking at the CI artifacts, any idea why there is a large spike here? 2024-07-11-141839_1417x1125_scrot

rtysonCLAS12 commented 3 months ago

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

dglazier commented 3 months ago

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

Makes sense, there is no z-vertex position from the FT (no tracker). FT electrons should not have a z-vertex cut applied.

rtysonCLAS12 commented 3 months ago

That's strange, maybe something to do with how the vertex is calculated fro electrons in the FT? The plots for the other particle types seem sensible.

Makes sense, there is no z-vertex position from the FT (no tracker). FT electrons should not have a z-vertex cut applied.

Ok thanks for pointing that out!