JeffersonLab / iguana

Preservation of common physics data analysis algorithms. Currently focused on HIPO data.
https://jeffersonlab.github.io/iguana/
GNU Lesser General Public License v3.0
2 stars 7 forks source link

Sector Finder: Support for charged & neutral particles, added action function and validator #243

Closed rtysonCLAS12 closed 1 month ago

rtysonCLAS12 commented 2 months ago

Before this pull request the config file was set up to take the same bank to find sector for charged and uncharged particles. This is problematic because the natural choice for charged particles (DC) is different from neutrals (calorimeters). SectorFinder also needed an action function and a validator

This pulls request introduces:

image

rtysonCLAS12 commented 2 months ago

@c-dilks not sure why the CI is failing, sorry

c-dilks commented 2 months ago

@c-dilks not sure why the CI is failing, sorry

looks like a transient pip problem; successful after retry

rtysonCLAS12 commented 1 month ago

Ok, thanks for the suggestions!

c-dilks commented 1 month ago

Ignore macOS CI failures, since the ROOT auto re-build over the weekend failed reproducibly.