Burp / stability cuts adversely affect Beam Mod

JeffersonLab / japan

Just Another Parity ANalyzer

7 stars 13 forks source link

Burp / stability cuts adversely affect Beam Mod #245

Open cameronc137 opened 5 years ago

cameronc137 commented 5 years ago

Environment: (where does this bug occur, have you tried other environments)

The cut in question (as of this current build) is one of kErrorFlag_BurpCut = 0x20000000 or kBeamStabilityError= 0x10000000

Problem

Beam mod trips the error flag due to its large (intentional) fluctutations

Proposed solutions

Use these flags in analysis to avoid these trips
Update JAPAN to have these flags overwritten by the BMOD flag
Turn these cuts back off

paulmking commented 5 years ago

I think the best solution is to have the BMOD analysis ignore the burp cut, and perhaps the stability cut if needed. Let's investigate further. There is active discussion in the BMW slack channel as I type this.