JeffersonLab / japan

Just Another Parity ANalyzer
7 stars 13 forks source link

Bugfix disable tree correlator #273

Closed paulmking closed 4 years ago

paulmking commented 4 years ago

These changes should allow us to run the "pass 0.5" with no tree outputs to determine where the minirun transitions will occur, and then run later analysis passes which combine the last minirun with the previous one if it has "too few" events.

cameronc137 commented 4 years ago

I have tested the results of placing a mandatory Max-burst index on JAPAN pass 2 ROOT files, within the disable-tree-correlator branch (technically I actually tested it in my old copy of the longer-burst branch with operations from today pulled into it).

It looks like the mechanics of it all work out.

Pass 0.5 -> do this:

Pass 2 -> do this:

We should see that the results should be exactly identical when no burst minimum limits are applied, and that does work. Additionally we should see that even the long bursts raw data (not the LRB corrected data though, as slopes will be changed as well with a pass1 using the longer bursts) should match, with appropriate cut to make the number of entries the smaller burst size. This is also seen, in the attachment.

I think this is ready to go: NewBurstsWork.pdf

cameronc137 commented 4 years ago

PNG image