search

JeffersonLab / japan

Just Another Parity ANalyzer
7 stars 13 forks source link

Cuts for PREX respin cleanup #287

Closed cameronc137 closed 4 years ago

cameronc137 commented 4 years ago

BPM 11 wire cut was missing from 3403.

Also, runs before 3912 lack BPM burp cuts, but the "good" cut diagnostics we saw during prompt running depended on the old version of the analyzer. So, it is worth checking if the burp cuts from 3912-> should be added to <-3912 runs.

We will also want to make sure the event cuts match the BCM normalizer (once Paul fixes that up), which will be its own ordeal of editing map files.

Other than these points everything looks fine for PREX maps, other than the quite large number of maps and our unfortunately frequent use of single-run event cut files for cleaning up noisy beam.

leafybillow commented 4 years ago

It is determined by whether or not BPM 11 is included in dithering and standard regression. We are not using 11X for beam correction for the first 3 slugs even though it already existed since slug 2. ( I am not sure why not using 11X for slug 2 and 3. It was guided by dithering configuration we have from PREX prompt)

Run 3403 belongs to slug 3 so we didn't have BPM 11 in the global cut. Also, we agree not to change event cut configuration for prex-respin2 at this point unless it is necessary.

cameronc137 commented 4 years ago

Oh nice, I see. In that case these changes can be ignored :+1:

paulmking commented 4 years ago

Since we want bpm11 used routinely in almost all slugs, it should be in the event cuts if it isn't already.

Sent from my mobile device.

From: Tao Ye notifications@github.com Sent: Tuesday, May 19, 2020 6:23:27 PM To: JeffersonLab/japan japan@noreply.github.com Cc: Paul King pking@jlab.org; Review requested review_requested@noreply.github.com Subject: [EXTERNAL] Re: [JeffersonLab/japan] Cuts for PREX respin cleanup (#287)

It is determined by whether or not BPM 11 is included in dithering and standard regression. We are not using 11X for beam correction for the first 3 slugs even though it already existed since slug 2. ( I am not sure why not using 11X for slug 2 and 3. It was guided by dithering configuration we have from PREX prompt)

Run 3403 belongs to slug 3 so we didn't have BPM 11 in the global cut. Also, we agree not to change event cut configuration for prex-respin2 at this point unless it is necessary.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_japan_pull_287-23issuecomment-2D631115385&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=0j7LsbAZ7ALovZkXAFR8Dw&m=Jcu6aSue20Rx4RS0DogVGnwbY5z1RdEHc9LEmJz2tS0&s=KbRam9ub4FT3vj3fVxX0nHeu-x7LkKCEKHkcXm0gZZw&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AB55ZLF7CHIVXP6FEQK6K73RSMBF7ANCNFSM4NFMFIZA&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=0j7LsbAZ7ALovZkXAFR8Dw&m=Jcu6aSue20Rx4RS0DogVGnwbY5z1RdEHc9LEmJz2tS0&s=-aphi5k9pKp6OkbJD7wNRHYQh4-F5FEZ5ou8Z9QEEhQ&e=.

paulmking commented 4 years ago

@leafybillow What is the first run for which the PREX2 respin1 postpan and dithering were using the BPM11 & 12 combination?

leafybillow commented 4 years ago

@leafybillow What is the first run for which the PREX2 respin1 postpan and dithering were using the BPM11 & 12 combination?

@paulmking
For respin1, it was run 3404, the first run using combined BPM for beam correction in dithering and postpan.

For respin2, after checking with Ye Tian, she thinks it is better to start from run 3398. The dithering corrector map files have been commited for PR for this change.

cameronc137 commented 4 years ago

These cut files should get the BPM burp cut changes that the other PRs are doing too.