1 implement hall b dataparser for aidapt

JeffersonLab / jlab_datascience_exp_hall

MIT License

0 stars 1 forks source link

1 implement hall b dataparser for aidapt #2

Closed sgoldenCS closed 1 month ago

sgoldenCS commented 8 months ago

Issue #1 should essentially be resolved by this pull request. The parser implements all functions in the current version of the jlab_datascience_core interface, however some implementations are trivial ones as mentioned in the comment to the issue.

dlersch commented 7 months ago

@sgoldenCS This looks really good. Please add unit-tests and a script that runs them all for aidapt. Let me know if you need help with this this.

dlersch commented 1 month ago

Looks good to me. there are a few minor things that need to be ironed out, but I will address them in separate issues. it is important that we get the current code into main, so that our collaborators from Hall B have access. I am going to approve this pr.