JeffersonLab / qphix

QCD for Intel Xeon Phi and Xeon processors
http://jeffersonlab.github.io/qphix/
Other
13 stars 11 forks source link

Fix KNC specific magic numbers #19

Open bjoo opened 8 years ago

bjoo commented 8 years ago

As we evolve the specific KNC magic numbers of 240 threads may become inappropriate, even for KNC where we can have e.g. 244 in some cases. I should fix this, especially in the BLAS/Inner Product section where it can cause mayhem.

martin-ueding commented 7 years ago

What about things like _mm_prefetch((const char *)( ((*clBase).diag1[ 0 ] +240) ), _MM_HINT_T0); in the AVX512 kernels? Is that 240 also a KNC magic number?

ddkalamk commented 7 years ago

No, this is simply offset for prefetching from base address and nothing to do with KNC. Should be same for all ISAs.

From: Martin Ueding [mailto:notifications@github.com] Sent: Saturday, April 29, 2017 6:50 PM To: JeffersonLab/qphix qphix@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [JeffersonLab/qphix] Fix KNC specific magic numbers (#19)

What about things like _mm_prefetch((const char )( ((clBase).diag1[ 0 ] +240) ), _MM_HINT_T0); in the AVX512 kernels? Is that 240 also a KNC magic number?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/JeffersonLab/qphix/issues/19#issuecomment-298168619, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIYlT6LlQ8X68CQrAJOXN2Q8Dn7swPnjks5r0zj5gaJpZM4H_O_j.