bjoo
commented
7 years ago Hi Martin, Yes, please feel free to check in the .clang-format file. I have been using Eclipse, which I think uses some different formatter, but if it helps you please use it. For now, it would be helpful if there was ot a hard rule to automatically reformat things with a pre-check in hook, until I see better what this code does.
On your other questions: Thorsten at NERSC has been swamped last week, so we couldn’t sync up, either as regards the Cori Strong Scaling data or Jinja yet. I did have a conversation about my colleague at Intel regarding CMake. As far as I know it has currently been done in qphix-codegen only, and so it may not yet be too much help for us in QPhiX just yet.
Best, B
On Mar 25, 2017, at 12:51 PM, Martin Ueding notifications@github.com wrote:
I use clang-format for all my code, so it is easy to format in a particular way.
In QPhiX, I don't really see what the style should be. Currently I have something like this:
• Indent with 4 spaces • Break curly braces for functions • Align pointers to the right (int foo instead of int foo) • Column limit of 80 That is the .clang-format file that I have in this repository:
Language: Cpp
BasedOnStyle: LLVM
AccessModifierOffset: -4 AlignAfterOpenBracket: Align AlignConsecutiveAssignments: false AlignConsecutiveDeclarations: false AlignEscapedNewlinesLeft: false AlignOperands: true AlignTrailingComments: false AllowAllParametersOfDeclarationOnNextLine: true AllowShortBlocksOnASingleLine: false AllowShortCaseLabelsOnASingleLine: false AllowShortFunctionsOnASingleLine: None AllowShortIfStatementsOnASingleLine: false AllowShortLoopsOnASingleLine: false AlwaysBreakAfterDefinitionReturnType: None AlwaysBreakAfterReturnType: None AlwaysBreakBeforeMultilineStrings: false AlwaysBreakTemplateDeclarations: true BinPackArguments: false BinPackParameters: false BraceWrapping :
AfterClass: false
AfterControlStatement: false
AfterEnum: false
AfterFunction: false
AfterNamespace: false
AfterObjCDeclaration: false
AfterStruct: false
AfterUnion: false
BeforeCatch: false
BeforeElse: false
IndentBraces: false BreakBeforeBinaryOperators: None BreakBeforeBraces: Linux BreakBeforeTernaryOperators: true BreakConstructorInitializersBeforeComma: false ColumnLimit: 80 CommentPragmas: '^ IWYU pragma:' ConstructorInitializerAllOnOneLineOrOnePerLine: false ConstructorInitializerIndentWidth: 4 ContinuationIndentWidth: 4 Cpp11BracedListStyle: true DerivePointerAlignment: false DisableFormat: false ExperimentalAutoDetectBinPacking: false ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ] IncludeCategories :
Regex: '^"(llvm|llvm-c|clang|clang-c)/'
Priority: 2
Regex: '^(<|"(gtest|isl|json)/)'
Priority: 3
Regex: '.*'
Priority: 1 IndentCaseLabels: false IndentWidth: 4 IndentWrappedFunctionNames: false KeepEmptyLinesAtTheStartOfBlocks: true MacroBlockBegin: '' MacroBlockEnd: '' MaxEmptyLinesToKeep: 1 NamespaceIndentation: None ObjCBlockIndentWidth: 2 ObjCSpaceAfterProperty: false ObjCSpaceBeforeProtocolList: true PenaltyBreakBeforeFirstCallParameter: 19 PenaltyBreakComment: 300 PenaltyBreakFirstLessLess: 120 PenaltyBreakString: 1000 PenaltyExcessCharacter: 1000000 PenaltyReturnTypeOnItsOwnLine: 60 PointerAlignment: Right ReflowComments: true SortIncludes: false SpaceAfterCStyleCast: false SpaceBeforeAssignmentOperators: true SpaceBeforeParens: ControlStatements SpaceInEmptyParentheses: false SpacesBeforeTrailingComments: 1 SpacesInAngles: false SpacesInContainerLiterals: true SpacesInCStyleCastParentheses: false SpacesInParentheses: false SpacesInSquareBrackets: false Standard: Cpp11 TabWidth: 8 UseTab: Never
...
It would be great if I could check in some .clang-format file into the devel branch. Then it would be easy for me (and perhaps others) to format added code in a uniform way.
What would be the style options that are desired?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
martin-ueding
I use
clang-formatfor all my code, so it is easy to format in a particular way.In QPhiX, I don't really see what the style should be. Currently I have something like this:
int *fooinstead ofint* foo)That is the
.clang-formatfile that I have in this repository:It would be great if I could check in some
.clang-formatfile into thedevelbranch. Then it would be easy for me (and perhaps others) to format added code in a uniform way.What would be the style options that are desired?