chandabindu
commented
2 years ago The implementation of collimator 5 seems okay based on page 7 of docDB 797. But, the collimator 5 is moved upstream by 40.106 mm (Upstream face from z=7547.93 mm tp z=7507.824 mm.
The purpose of the 'edge-cut' at the inner side of collimator 5 is unclear to me. I believe it is to machining - to avoid knife-edge. Other aspects are okay.
We may have to come up with a new acceptance boundary for the inner edges of collimator 5.
But, that would be part of a future pull request. I'm okay with this pull request.
Work in progress. Do not merge yet. This should in principle resolve all overlap issues in the hybrid region with the integration of updated values from latest CAD.
Running some test sims now to compare particle distribution at main detector plane with develop. Should be ready to merge once that's complete.