search

JeffersonLab / remoll

Simulations for the MOLLER Experiment at Jefferson Lab, http://moller.jlab.org
http://jeffersonlab.github.io/remoll/
11 stars 55 forks source link

Increasing the azimuthal extent of the subtracted annulus for Collima… #570

Closed rahmans1 closed 2 years ago

rahmans1 commented 2 years ago

The inner radius of collimator 6B downstream piece wasn't properly sculpted because of incorrect azimuthal extent in subtracted annulus. This change should fix that.

rahmans1 commented 2 years ago

@chandabindu A comparison between before and after. You can see narrow lines at the azimuthal extremes on the inner radius in the before case but not the after. Please double check before merging. Before: before After: Screenshot from 2022-09-06 14-26-50

I am wondering if there is any downside to using full azimuth annulus (startphi=0, deltaphi=360) for the subtracted volumes. That would remove the possibility of needing to tune this extent if other parameters change. @wdconinc Would there be any noticeable performance effect if a full azimuth cone is used for subtraction?

chandabindu commented 2 years ago

@wdconinc , could you please review and merge these changes to the develop branch? I am planning to run a few simulations with the updated changes. Thanks.