Closed rahmans1 closed 1 year ago
I think the lead donut is now integrated through the pion system because they are not easily disentangled. @Elhamm1 can confirm.
I think the lead donut is now integrated through the pion system because they are not easily disentangled. @Elhamm1 can confirm.
Right now nothing relevant to pion detector is turned on in mollerMother. I am going by @Elhamm1 's branch where she has the donut system turned on https://github.com/Elhamm1/remoll/blob/PionDetectorSystemRotated/geometry/mollerMother.gdml. So, I am assuming that volume contains everything relevant to pion.
Yes, the pion was disabled in https://github.com/JeffersonLab/remoll/pull/571/. This is the right fix. I'll approve.
I won't worry about the failing checks I guess.
Seems like lead donut was turned off in moller mother in one of the shielding related PRs. Guessing this should be turned on.