JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

New matching scheme v2 #1008

Closed staylorjlab closed 6 years ago

staylorjlab commented 6 years ago

This pull request is for a major overhaul of how tracks are matched to the other detectors. Instead of relying on DReferenceTrajectory (which required an additional swim of the track through the field after the final fit), the new code in DTrackFitterKalmanSIMD passes projection data derived from the internal representation of the trajectory out to the calling routines (DTrackTimeBased and DTrackWireBased). Consequently the DTrackWireBased and DTrackTimeBased objects no longer need pointers to the DReferenceTrajectory *rt objects but instead contain a map of extrapolations to the various detectors. All of the matching routines in the PID library and the charged clusterizer in the BCAL library have changed to reflect the new interface. All the plugins that relied on the old reference trajectory rt have also been changed, but I have not done any extensive checking of these (because there are many) beyond compiling and running each of them to make sure that they at least don't crash.

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^NewMatchingSchemeV2/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^NewMatchingSchemeV2/tests/log

Build log: /work/halld/pull_request_test/sim-recon^NewMatchingSchemeV2/make_NewMatchingSchemeV2.log Build report: /work/halld/pull_request_test/sim-recon^NewMatchingSchemeV2/report_NewMatchingSchemeV2.txt Location of build: /work/halld/pull_request_test/sim-recon^NewMatchingSchemeV2

mikestaib commented 6 years ago

Any chance of adding the new matching to the straight line fitting? This code breaks the BCAL shower creation with cosmic tracks I think.

src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.cc

staylorjlab commented 6 years ago

Yes, I will work on it. Simon On 12/15/2017 03:49 PM, mikestaib wrote:

Any chance of adding the new matching to the staring line fitting? This code breaks the BCAL shower creation with cosmic tracks I think.

src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.cc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1008-23issuecomment-2D352108414&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m=1jZa3XzoQZ6hcbKW77PWYO0XVSBXD8ESXYwf22UiPGo&s=emSCEgymLHQ-NX1bn_N6tcOSkOcZ8LiLjcdKWLpcvSw&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMqSUOPhYl3Ef-5FsrFwQ8MB4F0OfKJE07ks5tAttbgaJpZM4RD70X&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m=1jZa3XzoQZ6hcbKW77PWYO0XVSBXD8ESXYwf22UiPGo&s=ZmQ7Fpl1A83R1MkhkG6LtinKQrAPXvw_TxLyuEZrNH4&e=.