search

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

Kalman pulls #1053

Closed staylorjlab closed 6 years ago

staylorjlab commented 6 years ago

Fixes a bug that prevented the pulls vector being filled for high CDC ring numbers

nsjarvis commented 6 years ago

Yay!! I will try this with the calibration plugin.

On 31 January 2018 at 09:40, staylorjlab notifications@github.com wrote:

Fixes a bug that prevented the pulls vector being filled for high CDC ring numbers

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/1053 Commit Summary

  • make sure the smoothed results from the fit before the chi2 criterion is met is stored to the pulls vector
  • Fixed very subtle bug in smoothing code for central tracks: I had to avoid using the special method that performs AdCA^T on the difference dC of the covariance matrix C relative to Cs (after smoothing) taking advantage of the fact that the end result of this operation should be a symmetric matrix because this appears to lead to an unacceptable level of roundoff errors to the extent that explicitly performing the operation A.dC.A^T gives a different answer (some of the covariance matrix elements are quite small, on the order of 1x10-6). I also fixed a bug in the extrapolations in the CDC region (was not far enough out in the region of the outermost hit on the track).
  • Merge branch 'master' into KalmanPulls

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1053, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7hVoqkPyE0V90na36ri4A0vBrMHEK-ks5tQHtJgaJpZM4R0Erf .

gluex commented 6 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^KalmanPulls/make_KalmanPulls.log Build report: /work/halld/pull_request_test/sim-recon^KalmanPulls/report_KalmanPulls.txt Location of build: /work/halld/pull_request_test/sim-recon^KalmanPulls

markito3 commented 6 years ago

Probably a side effect of the new default non-sim-recon versions inappropriate for current sim-recon master branch. Let me have a look...

On 01/31/2018 09:46 AM, gluex wrote:

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^KalmanPulls/make_KalmanPulls.log https://halldweb.jlab.org/pull_request_test/sim-recon%5EKalmanPulls/make_KalmanPulls.log Build report: /work/halld/pull_request_test/sim-recon^KalmanPulls/report_KalmanPulls.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5EKalmanPulls/report_KalmanPulls.txt Location of build: /work/halld/pull_request_test/sim-recon^KalmanPulls

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1053-23issuecomment-2D361953765&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=BLzGYqjPOj4HItNW8CMttGy0g_HnjFd7c8oFbVbJfuw&s=l_UjKfpKd--ZnQJvFbnZ8fs8R0LCLhEYqRRw4Ie3qVA&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFZvve4XFoFPynGpTpdnvYBWn8IaAkp7ks5tQHzPgaJpZM4R0Erf&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=BLzGYqjPOj4HItNW8CMttGy0g_HnjFd7c8oFbVbJfuw&s=-cYLGyVLI5fNIYRXzO6I664-aYBgfxLm1Mm_vze4_YI&e=.

-- Mark Ito, marki@jlab.org, (757)269-5295

nsjarvis commented 6 years ago

It built fine for me, I have version set 2.25 (mostly).

On 31 January 2018 at 10:53, Mark M. Ito notifications@github.com wrote:

Probably a side effect of the new default non-sim-recon versions inappropriate for current sim-recon master branch. Let me have a look...

On 01/31/2018 09:46 AM, gluex wrote:

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^KalmanPulls/make_KalmanPulls.log

https://halldweb.jlab.org/pull_request_test/sim-recon% 5EKalmanPulls/make_KalmanPulls.log Build report: /work/halld/pull_request_test/sim-recon^KalmanPulls/report_KalmanPulls.txt

https://halldweb.jlab.org/pull_request_test/sim-recon% 5EKalmanPulls/report_KalmanPulls.txt Location of build: /work/halld/pull_request_test/sim-recon^KalmanPulls

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_JeffersonLab_sim-2Drecon_pull_1053- 23issuecomment-2D361953765&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI 4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=BLzGYqjPOj4HItNW8CMttGy0g_ HnjFd7c8oFbVbJfuw&s=l_UjKfpKd--ZnQJvFbnZ8fs8R0LCLhEYqRRw4Ie3qVA&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_ AFZvve4XFoFPynGpTpdnvYBWn8IaAkp7ks5tQHzPgaJpZM4R0Erf&d=DwMFaQ&c= lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m= BLzGYqjPOj4HItNW8CMttGy0g_HnjFd7c8oFbVbJfuw&s=-cYLGyVLI5fNIYRXzO6I664- aYBgfxLm1Mm_vze4_YI&e=.

-- Mark Ito, marki@jlab.org, (757)269-5295 <(757)%20269-5295>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1053#issuecomment-361975930, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7hVqSAGB2DoLojl3wZaF9KGc9h2r_Hks5tQIyTgaJpZM4R0Erf .

markito3 commented 6 years ago

Yes, 2.25 is the last version set that works with the current sim-recon master branch. I have just restarted the test build with that version set.

On 01/31/2018 11:03 AM, nsjarvis wrote:

It built fine for me, I have version set 2.25 (mostly).

On 31 January 2018 at 10:53, Mark M. Ito notifications@github.com wrote:

Probably a side effect of the new default non-sim-recon versions inappropriate for current sim-recon master branch. Let me have a look...

On 01/31/2018 09:46 AM, gluex wrote:

Build status for this pull request: FAILURE

Build log:

/work/halld/pull_request_test/sim-recon^KalmanPulls/make_KalmanPulls.log

https://halldweb.jlab.org/pull_request_test/sim-recon% 5EKalmanPulls/make_KalmanPulls.log Build report:

/work/halld/pull_request_test/sim-recon^KalmanPulls/report_KalmanPulls.txt

https://halldweb.jlab.org/pull_request_test/sim-recon% 5EKalmanPulls/report_KalmanPulls.txt Location of build: /work/halld/pull_request_test/sim-recon^KalmanPulls

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_JeffersonLab_sim-2Drecon_pull_1053- 23issuecomment-2D361953765&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI 4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=BLzGYqjPOj4HItNW8CMttGy0g_ HnjFd7c8oFbVbJfuw&s=l_UjKfpKd--ZnQJvFbnZ8fs8R0LCLhEYqRRw4Ie3qVA&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_ AFZvve4XFoFPynGpTpdnvYBWn8IaAkp7ks5tQHzPgaJpZM4R0Erf&d=DwMFaQ&c= lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m= BLzGYqjPOj4HItNW8CMttGy0g_HnjFd7c8oFbVbJfuw&s=-cYLGyVLI5fNIYRXzO6I664- aYBgfxLm1Mm_vze4_YI&e=.

-- Mark Ito, marki@jlab.org, (757)269-5295 <(757)%20269-5295>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub

https://github.com/JeffersonLab/sim-recon/pull/1053#issuecomment-361975930, or mute the thread

https://github.com/notifications/unsubscribe-auth/AO7hVqSAGB2DoLojl3wZaF9KGc9h2r_Hks5tQIyTgaJpZM4R0Erf .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1053-23issuecomment-2D361979209&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=9dSILC0lfmkVwKfqAoTfRcebF_anUyMetnXTDuGYN6Y&s=1or0iOdlzwBg4MX-VSKhE9Ls9x2JO0P50eC84Ui139I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFZvvQ5kt4g6XteotjPadAg3Whc-2DXzI-5Fks5tQI6-5FgaJpZM4R0Erf&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=9dSILC0lfmkVwKfqAoTfRcebF_anUyMetnXTDuGYN6Y&s=ASuK5c8O8h5l9SeHoyH4gn7AZEcHEsGUU0I9IdpaMzA&e=.

-- Mark Ito, marki@jlab.org, (757)269-5295

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^KalmanPulls/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^KalmanPulls/tests/log

Build log: /work/halld/pull_request_test/sim-recon^KalmanPulls/make_KalmanPulls.log Build report: /work/halld/pull_request_test/sim-recon^KalmanPulls/report_KalmanPulls.txt Location of build: /work/halld/pull_request_test/sim-recon^KalmanPulls