JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

Trigger fix #1122

Closed staylorjlab closed 6 years ago

staylorjlab commented 6 years ago

Remove code referencing an older version of the trigger emulation that always defaulted to 1 (trigger found) if the newer emulation code failed, which effectively meant that the trigger was always satisfied.

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^TriggerFix/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^TriggerFix/tests/log

Build log: /work/halld/pull_request_test/sim-recon^TriggerFix/make_TriggerFix.log Build report: /work/halld/pull_request_test/sim-recon^TriggerFix/report_TriggerFix.txt Location of build: /work/halld/pull_request_test/sim-recon^TriggerFix

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^TriggerFix/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^TriggerFix/tests/log

Build log: /work/halld/pull_request_test/sim-recon^TriggerFix/make_TriggerFix.log Build report: /work/halld/pull_request_test/sim-recon^TriggerFix/report_TriggerFix.txt Location of build: /work/halld/pull_request_test/sim-recon^TriggerFix