search

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

do not modify CDC drift time before cutting for dEdx calculation. #1156

Closed zihlmann closed 6 years ago

zihlmann commented 6 years ago

modified this line to NOT change tdrift before timing cut double dt=cdchits[i]->tdrift; //-tflight-t0;

nsjarvis commented 6 years ago

Hey Beni

I put my own dedx-time-cut into CalcdEdxHit, into the "if (dx>0)" immediately after double dx=CalcdXHit That is a better place for me as it's also where I am testing out corrections with dx. I have not committed the code because it is an under-development mess.

Naomi.

On Tue, Jun 26, 2018 at 10:02 AM, zihlmann notifications@github.com wrote:

modified this line to NOT change tdrift before timing cut double dt=cdchits[i]->tdrift; //-tflight-t0;

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/1156 Commit Summary

  • do not modify CDC drift time before cutting for dEdx calculation.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1156, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7hVtY3ETkH53Yl_kVrnwWUGRBAP3Zqks5uAj7fgaJpZM4U4AVL .

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^CDCtime4dEdx/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^CDCtime4dEdx/tests/log

Build log: /work/halld/pull_request_test/sim-recon^CDCtime4dEdx/make_CDCtime4dEdx.log Build report: /work/halld/pull_request_test/sim-recon^CDCtime4dEdx/report_CDCtime4dEdx.txt Location of build: /work/halld/pull_request_test/sim-recon^CDCtime4dEdx

zihlmann commented 6 years ago

Hi Naomi,

now I am confused. I thought Simon implemented that dEdx is calculated in both ways using amplitude AND integral???? that should have been done exacltly where I do the modification . CalcdEdxHit should calculate dE and dx twice once for amplitude and once for integral. The timing cut should not be done inside that function but outside. that is only my oppinion.

cheer,s Beni

On 06/26/2018 10:11 AM, nsjarvis wrote:

Hey Beni

I put my own dedx-time-cut into CalcdEdxHit, into the "if (dx>0)" immediately after double dx=CalcdXHit That is a better place for me as it's also where I am testing out corrections with dx. I have not committed the code because it is an under-development mess.

Naomi.

On Tue, Jun 26, 2018 at 10:02 AM, zihlmann notifications@github.com wrote:

modified this line to NOT change tdrift before timing cut double dt=cdchits[i]->tdrift; //-tflight-t0;

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/1156 Commit Summary

  • do not modify CDC drift time before cutting for dEdx calculation.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1156, or mute the thread

https://github.com/notifications/unsubscribe-auth/AO7hVtY3ETkH53Yl_kVrnwWUGRBAP3Zqks5uAj7fgaJpZM4U4AVL .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1156-23issuecomment-2D400323362&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N-H01oqTJ5vLjRalTE&m=pwMHVpyPWOog9fzVYtAibQTGj5Jn0zoikY9jVYQTbjg&s=NZv8YIFW9-2IPvTJw7sSPBAHpxFlpSC3Njax5GlW9NE&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMvwCxWEirrVnOHxxUmdFKEbkilmFIrMks5uAkEagaJpZM4U4AVL&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N-H01oqTJ5vLjRalTE&m=pwMHVpyPWOog9fzVYtAibQTGj5Jn0zoikY9jVYQTbjg&s=8IIDzKRq5e-OtVXsR9cZZe55WxcjoTbKEIomefrzWd0&e=.

staylorjlab commented 6 years ago

Yes, I agree that the cut should be done outside that function.

On 06/26/2018 11:36 AM, zihlmann wrote:

Hi Naomi,

now I am confused. I thought Simon implemented that dEdx is calculated in both ways using amplitude AND integral???? that should have been done exacltly where I do the modification . CalcdEdxHit should calculate dE and dx twice once for amplitude and once for integral. The timing cut should not be done inside that function but outside. that is only my oppinion.

cheer,s Beni

On 06/26/2018 10:11 AM, nsjarvis wrote:

Hey Beni

I put my own dedx-time-cut into CalcdEdxHit, into the "if (dx>0)" immediately after double dx=CalcdXHit That is a better place for me as it's also where I am testing out corrections with dx. I have not committed the code because it is an under-development mess.

Naomi.

On Tue, Jun 26, 2018 at 10:02 AM, zihlmann notifications@github.com wrote:

modified this line to NOT change tdrift before timing cut double dt=cdchits[i]->tdrift; //-tflight-t0;

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/1156 Commit Summary

  • do not modify CDC drift time before cutting for dEdx calculation.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1156, or mute the thread

https://github.com/notifications/unsubscribe-auth/AO7hVtY3ETkH53Yl_kVrnwWUGRBAP3Zqks5uAj7fgaJpZM4U4AVL

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1156-23issuecomment-2D400323362&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N-H01oqTJ5vLjRalTE&m=pwMHVpyPWOog9fzVYtAibQTGj5Jn0zoikY9jVYQTbjg&s=NZv8YIFW9-2IPvTJw7sSPBAHpxFlpSC3Njax5GlW9NE&e=,

or mute the thread

https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMvwCxWEirrVnOHxxUmdFKEbkilmFIrMks5uAkEagaJpZM4U4AVL&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N-H01oqTJ5vLjRalTE&m=pwMHVpyPWOog9fzVYtAibQTGj5Jn0zoikY9jVYQTbjg&s=8IIDzKRq5e-OtVXsR9cZZe55WxcjoTbKEIomefrzWd0&e=.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1156-23issuecomment-2D400355430&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m=zbMWH6XDW9hlhm7DlOtpxxHcve6qWZMkyXyZXGwh3j8&s=fWj6lWsuzqXSPMYZA-umIxa7Y84Lbt7zoT7WV_Zl5TI&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMqSUJICb5ssR-5FnhJ6obnTWTOgDQemWXks5uAlURgaJpZM4U4AVL&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m=zbMWH6XDW9hlhm7DlOtpxxHcve6qWZMkyXyZXGwh3j8&s=xPtoo8lw0fJs_zdp_7jEv02Bv9tT-Pl4E8UwLyV1aVc&e=.

nsjarvis commented 6 years ago

OK, I forgot about the second dE/dx - my code predates that. I'm just working w amplitude for the time being.

Naomi.

On Tue, Jun 26, 2018 at 11:38 AM, staylorjlab notifications@github.com wrote:

Yes, I agree that the cut should be done outside that function.

On 06/26/2018 11:36 AM, zihlmann wrote:

Hi Naomi,

now I am confused. I thought Simon implemented that dEdx is calculated in both ways using amplitude AND integral???? that should have been done exacltly where I do the modification . CalcdEdxHit should calculate dE and dx twice once for amplitude and once for integral. The timing cut should not be done inside that function but outside. that is only my oppinion.

cheer,s Beni

On 06/26/2018 10:11 AM, nsjarvis wrote:

Hey Beni

I put my own dedx-time-cut into CalcdEdxHit, into the "if (dx>0)" immediately after double dx=CalcdXHit That is a better place for me as it's also where I am testing out corrections with dx. I have not committed the code because it is an under-development mess.

Naomi.

On Tue, Jun 26, 2018 at 10:02 AM, zihlmann notifications@github.com wrote:

modified this line to NOT change tdrift before timing cut double dt=cdchits[i]->tdrift; //-tflight-t0;

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/1156 Commit Summary

  • do not modify CDC drift time before cutting for dEdx calculation.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1156, or mute the thread

https://github.com/notifications/unsubscribe-auth/AO7hVtY3ETkH53Yl_ kVrnwWUGRBAP3Zqks5uAj7fgaJpZM4U4AVL

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_JeffersonLab_sim-2Drecon_pull_1156- 23issuecomment-2D400323362&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI 4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N-H01oqTJ5vLjRalTE&m= pwMHVpyPWOog9fzVYtAibQTGj5Jn0zoikY9jVYQTbjg&s=NZv8YIFW9- 2IPvTJw7sSPBAHpxFlpSC3Njax5GlW9NE&e=,

or mute the thread

https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_ AMvwCxWEirrVnOHxxUmdFKEbkilmFIrMks5uAkEagaJpZM4U4AVL&d=DwMFaQ&c= lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=o4lft6oWsUt3fPjSD1CFMTzi5N- H01oqTJ5vLjRalTE&m=pwMHVpyPWOog9fzVYtAibQTGj5Jn0z oikY9jVYQTbjg&s=8IIDzKRq5e-OtVXsR9cZZe55WxcjoTbKEIomefrzWd0&e=.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_JeffersonLab_sim-2Drecon_pull_1156- 23issuecomment-2D400355430&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI 4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m=zbMWH6XDW9hlhm7DlOtpxxHcve6qWZ MkyXyZXGwh3j8&s=fWj6lWsuzqXSPMYZA-umIxa7Y84Lbt7zoT7WV_Zl5TI&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_AMqSUJICb5ssR- 5FnhJ6obnTWTOgDQemWXks5uAlURgaJpZM4U4AVL&d=DwMFaQ&c= lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=RgVWzOo5vEGwTw93BfU_Og&m= zbMWH6XDW9hlhm7DlOtpxxHcve6qWZMkyXyZXGwh3j8&s=xPtoo8lw0fJs_ zdp_7jEv02Bv9tT-Pl4E8UwLyV1aVc&e=.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1156#issuecomment-400356331, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7hVi0uksC9paqlrxmqYtqrR4iplr4Iks5uAlWEgaJpZM4U4AVL .