search

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

Updates to mergeTrees.C #1162

Closed abarnes12 closed 6 years ago

abarnes12 commented 6 years ago

Previously, the comparison of reactions compared any branch with "Plus" with the other reaction's "Plus" branches. This prevented the comparison of PiPlus with Protons. This update ignores the particle type and directly compares the trackID from each reaction.

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^aebarnes-chisq/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^aebarnes-chisq/tests/log

Build log: /work/halld/pull_request_test/sim-recon^aebarnes-chisq/make_aebarnes-chisq.log Build report: /work/halld/pull_request_test/sim-recon^aebarnes-chisq/report_aebarnes-chisq.txt Location of build: /work/halld/pull_request_test/sim-recon^aebarnes-chisq

jrstevenjlab commented 6 years ago

Sorry, I missed this before the merge, but does this change still support reactions with photons? It looks like that flag is turned off in the updated code.

On Jul 3, 2018, at 1:07 PM, Sean Dobbs notifications@github.com wrote:

Merged #1162 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1162&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=cIyw2PFFtpuc0ZvlKFxF6UnQ9C9dChESxxwL_XrGKB8&m=hdkTbtjBkBeYeGGLLFbfHiFJR9RWJZBY9fGXwNWszHs&s=VnExnd70jDlXtlKUGS3j5foC-DXihv3cYxP4M2PLPw8&e=.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1162-23event-2D1714566997&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=cIyw2PFFtpuc0ZvlKFxF6UnQ9C9dChESxxwL_XrGKB8&m=hdkTbtjBkBeYeGGLLFbfHiFJR9RWJZBY9fGXwNWszHs&s=oEbo7fDqdPfq-mClnaOOB7Az8HMRetbu_RMb-BsbXzI&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMoSBo5JOvV52T72KiURWk5DeTbnmu0Iks5uC6TAgaJpZM4U-5F-5FBh&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=cIyw2PFFtpuc0ZvlKFxF6UnQ9C9dChESxxwL_XrGKB8&m=hdkTbtjBkBeYeGGLLFbfHiFJR9RWJZBY9fGXwNWszHs&s=CtSSQ3hBSTnP_w_H8VnpurM_-z6R5aL6DX8hMLevIfs&e=.

abarnes12 commented 6 years ago

Whoops, yes, I accidentally disabled that while making it work for proton-antiproton compared with pi+pi-. It would be good to have some neutral trees to test this on. Any recommendation?

jrstevenjlab commented 6 years ago

You could try tree_pi0pippimB3_T4 vs tree_pi0kpkmB3 from 2017 analysis launch ver08 https://halldweb.jlab.org/wiki-private/index.php/Spring_2017_Analysis_Launch https://halldweb.jlab.org/wiki-private/index.php/Spring_2017_Analysis_Launch, which have neutrals, and would let you test the pi+pi- compared to the K+K-

On Jul 3, 2018, at 2:28 PM, Alex Barnes notifications@github.com wrote:

Whoops, yes, I accidentally disabled that while making it work for proton-antiproton compared with pi+pi-. It would be good to have some neutral trees to test this on. Any recommendation?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1162-23issuecomment-2D402251595&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=cIyw2PFFtpuc0ZvlKFxF6UnQ9C9dChESxxwL_XrGKB8&m=412pMXGTzNqGPezjX0nju1Yhl1JrE7cD60ZBcj-r04o&s=hp-seF8cP8w0c3ruRONInKWOm8pSdXkNJGiNw_JfDPI&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMoSBrB1-5FoD37TQMzA-2DirJlTWbp7NfZRks5uC7fcgaJpZM4U-5F-5FBh&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=cIyw2PFFtpuc0ZvlKFxF6UnQ9C9dChESxxwL_XrGKB8&m=412pMXGTzNqGPezjX0nju1Yhl1JrE7cD60ZBcj-r04o&s=Gb-voPEj28Fs0HvEcN1DpFOrVwxEidjJ4C59a1dXkuM&e=.