- fix a bug in the way hddmInput function loadInput handles the case

[rjones30]

with multiple delayed vertices. The original code for this case would shift the primary and secondary vertices in the event independently, which is not the intended behavior. It now generates a single time offset (the trigger time offset) for all vertices in the event, and if the generated vertex position is zero, randomizes the offset within the active region of the target, but then all vertices in an single event are offset by the same vector.

[gluex]

Test status for this pull request: FAILURE

Failures: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/failures.txt Summary: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/log

Build log: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log Build report: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt Location of build: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj

[gluex]

Test status for this pull request: FAILURE

Failures: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/failures.txt Summary: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/log

Build log: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log Build report: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt Location of build: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj

[markito3]

Folks --- Should we increase the time-out on some of these tests?

On 07/20/2018 09:44 PM, gluex wrote:

Test status for this pull request: FAILURE

Failures: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/failures.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-failures.txt Summary: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/summary.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-summary.txt Logs: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/log https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-logs

Build log: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log Build report: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt Location of build: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1172-23issuecomment-2D406762129&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=sVv8DlaK-ZM_l16rLysPA9qChYcMoTZ0n5AVgfQj2Ro&s=jdOay1sce8TMMf3m5nhQXCAhuzEZuH5xClM14N1bDEM&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFZvvZXF1X5WAdNfNoZwTcAIg95Lh-2Dwzks5uIod1gaJpZM4VZXIj&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=sVv8DlaK-ZM_l16rLysPA9qChYcMoTZ0n5AVgfQj2Ro&s=CJ5B90AFediHgmsFSJY1oASkqIBsEZkwWxKT_bPDYos&e=.

[sdobbs]

It would be good for now, but it would be better to figure out why things are taking longer...

On Sat, Jul 21, 2018 at 10:27 AM Mark M. Ito notifications@github.com wrote:

Folks --- Should we increase the time-out on some of these tests?

On 07/20/2018 09:44 PM, gluex wrote:

Test status for this pull request: FAILURE

Failures:

/work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/failures.txt

< https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-failures.txt

Summary:

/work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/summary.txt

< https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-summary.txt

Logs:

/work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/tests/log

< https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/tests-logs

Build log:

/work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log

< https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/make_fix_delayed_vertex_timing_rtj.log

Build report:

/work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt

< https://halldweb.jlab.org/pull_request_test/sim-recon%5Efix_delayed_vertex_timing_rtj/report_fix_delayed_vertex_timing_rtj.txt

Location of build: /work/halld/pull_request_test/sim-recon^fix_delayed_vertex_timing_rtj

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1172-23issuecomment-2D406762129&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=sVv8DlaK-ZM_l16rLysPA9qChYcMoTZ0n5AVgfQj2Ro&s=jdOay1sce8TMMf3m5nhQXCAhuzEZuH5xClM14N1bDEM&e=>,

or mute the thread < https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFZvvZXF1X5WAdNfNoZwTcAIg95Lh-2Dwzks5uIod1gaJpZM4VZXIj&d=DwMFaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=sVv8DlaK-ZM_l16rLysPA9qChYcMoTZ0n5AVgfQj2Ro&s=CJ5B90AFediHgmsFSJY1oASkqIBsEZkwWxKT_bPDYos&e= .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1172#issuecomment-406803858, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIJaq9juru7FtZVJmq3E6fTzrDKUqBQks5uI0hvgaJpZM4VZXIj .