search

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

RANT ABOUT THIS AT SOFTWARE MEETING #1180

Closed faustus123 closed 6 years ago

faustus123 commented 6 years ago

This fixes a couple of issues that seeped into the build system and code that effectively turned SQLITECPP, AMPTOOLS, and RCDB into hard requirements to do a core build.

A special wag of the finger to those responsible for making and accepting the pull request that made SQLiteCPP a strict requirement. This was done in spite of the numerous examples of how to conditionally add it throughout the sbms.py file, including the lines immediately following where the changes where made as these lines had to be moved in order to insert the change!

gluex commented 6 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^davidl_SBMS/make_davidl_SBMS.log Build report: /work/halld/pull_request_test/sim-recon^davidl_SBMS/report_davidl_SBMS.txt Location of build: /work/halld/pull_request_test/sim-recon^davidl_SBMS

faustus123 commented 6 years ago

The branch has been updated to fix the bugs that I think caused the build failure. Can someone re-issue the build test?

markito3 commented 6 years ago

It is already running. I didn't do anything. Maybe it gets re-started automatically when the branch receives a push?

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^davidl_SBMS/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^davidl_SBMS/tests/log

Build log: /work/halld/pull_request_test/sim-recon^davidl_SBMS/make_davidl_SBMS.log Build report: /work/halld/pull_request_test/sim-recon^davidl_SBMS/report_davidl_SBMS.txt Location of build: /work/halld/pull_request_test/sim-recon^davidl_SBMS

sdobbs commented 6 years ago

Yes if the branch associated with the PR is updated, the tests are automatically run again. On Thu, Jul 26, 2018 at 8:08 AM gluex notifications@github.com wrote:

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^davidl_SBMS/tests/summary.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5Edavidl_SBMS/tests-summary.txt Logs: /work/halld/pull_request_test/sim-recon^davidl_SBMS/tests/log https://halldweb.jlab.org/pull_request_test/sim-recon%5Edavidl_SBMS/tests-logs

Build log: /work/halld/pull_request_test/sim-recon^davidl_SBMS/make_davidl_SBMS.log https://halldweb.jlab.org/pull_request_test/sim-recon%5Edavidl_SBMS/make_davidl_SBMS.log Build report: /work/halld/pull_request_test/sim-recon^davidl_SBMS/report_davidl_SBMS.txt https://halldweb.jlab.org/pull_request_test/sim-recon%5Edavidl_SBMS/report_davidl_SBMS.txt Location of build: /work/halld/pull_request_test/sim-recon^davidl_SBMS

—

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/sim-recon/pull/1180#issuecomment-408091343, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIJavdaA5K-TwLfedW1xfInkWl7XUc-ks5uKb9egaJpZM4VgyaB .

sdobbs commented 6 years ago

@markito3, do we need to wait until after the split to merge these?

markito3 commented 6 years ago

You might be right. I forgot about the fact that changes to SBMS could mess up the split procedure. I don't know if this one does or not. We will have to look. I guess no merging yet...

On 07/27/2018 03:33 PM, Sean Dobbs wrote:

@markito3 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_markito3&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=syfQDnOGaTgJeFc0gGYOG8_MFqP5LItNCPIfsTca1tY&s=q3bBSUfIJAOXg0UR8QKlfsI_qJR73JlJhpCAFeH4JS4&e=, do we need to wait until after the split to merge these?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1180-23issuecomment-2D408518054&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=syfQDnOGaTgJeFc0gGYOG8_MFqP5LItNCPIfsTca1tY&s=uLxaY9Qcl8afIQzPmwWwkJqQtec8WHqG91oV_FqfTOw&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFZvvXUJvt8KwIPhC4lmBcA3wbD7KCiUks5uK2sGgaJpZM4VgyaB&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=JKPm21o4RG5_VIn2fXX6tQ&m=syfQDnOGaTgJeFc0gGYOG8_MFqP5LItNCPIfsTca1tY&s=ciEb3bC8rbRkaSm9VI3ctYJRVoY9aHno07ouU4fCHvU&e=.

-- Mark Ito, marki@jlab.org, (757)269-5295

sdobbs commented 6 years ago

I'm going to go ahead and merge this, since we are back to the wild west of development!

faustus123 commented 6 years ago

Some might characterize this more as bringing civilization to the savages ;)

Regards, -David

David Lawrence Ph.D. Staff Scientist, Thomas Jefferson National Accelerator Facility Newport News, VA davidl@jlab.org (757) 269-5567 W (757) 746-6697 C

On Jul 30, 2018, at 2:06 PM, Sean Dobbs notifications@github.com wrote:

I'm going to go ahead and merge this, since we are back to the wild west of development!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_sim-2Drecon_pull_1180-23issuecomment-2D408956977&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=DSufUSddsl3c0GGnbiwkxA&m=INjxz396LzT6S2D92aVqdn2qKf9ING5kNth9I1IU7mM&s=2zAeNx4VeIjKA1TIwINjlJE3wGXxCE7GlIzV8Nn4dgM&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMPm5X27s45ZL53f6HFHAa6iGtd6MwErks5uL0s3gaJpZM4VgyaB&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=DSufUSddsl3c0GGnbiwkxA&m=INjxz396LzT6S2D92aVqdn2qKf9ING5kNth9I1IU7mM&s=iK1cGLGx7kaxNfusIQGWoiCsZivTP2y06DA5TWKN4CM&e=.