JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

First stage of Geometry Updates #1189

Closed sdobbs closed 6 years ago

sdobbs commented 6 years ago

First pass at rewriting geometry code to better factorize it and to add in more alignment constants. Generally, put all the XML handling code in DGeometry, and centralize more of the calculations in there as well. Local detector classes are responsible for transforming the geometry into what is needed by the reconstruction algorithms.

TOF geometry generalization should help in the future as well.

Still a few more changes to make, but adding what I have now before the sim-recon split.

gluex commented 6 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/tests/log

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/make_sdobbs_geom_updates.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/report_sdobbs_geom_updates.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates

sdobbs commented 6 years ago

I hope someone merges me before sim-recon is locked! 😄

gluex commented 6 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/make_sdobbs_geom_updates.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/report_sdobbs_geom_updates.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates

gluex commented 6 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/make_sdobbs_geom_updates.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/report_sdobbs_geom_updates.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates

gluex commented 6 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/make_sdobbs_geom_updates.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates/report_sdobbs_geom_updates.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_geom_updates