search

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX
9 stars 14 forks source link

omega_skim plugin was flat-out broken prior to this. #955

Closed pmattjlab closed 7 years ago

pmattjlab commented 7 years ago

It assumed that it was the FIRST analysis channel that was run, and checking that channel to make the skim. So if it was p2pi_hists instead, it instead saved events that passed the RHO cuts. This is fixed now.

Also, it crashed on events that weren't a physics trigger. This is fixed now.

gluex commented 7 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^fix_omegaskim/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^fix_omegaskim/tests/log

Build log: /work/halld/pull_request_test/sim-recon^fix_omegaskim/make_fix_omegaskim.log Build report: /work/halld/pull_request_test/sim-recon^fix_omegaskim/report_fix_omegaskim.txt Location of build: /work/halld/pull_request_test/sim-recon^fix_omegaskim

mashephe commented 7 years ago

Thanks - can you remove the pi0 mass constraint and set the CL cut at 5%? This is tight but necessary.

This message was sent from my iPhone.

On Nov 6, 2017, at 10:57 AM, Paul Mattione notifications@github.com<mailto:notifications@github.com> wrote:

It assumed that it was the FIRST analysis channel that was run, and checking that channel to make the skim. So if it was p2pi_hists instead, it instead saved events that passed the RHO cuts. This is fixed now.

Also, it crashed on events that weren't a physics trigger. This is fixed now.

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/955

Commit Summary

File Changes

Patch Links:

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/JeffersonLab/sim-recon/pull/955, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM3V6Bk6TSwObKSOUZthXV_vsJqm2XBBks5szznOgaJpZM4QTi_9.

mashephe commented 7 years ago

Even if the pi0 mass constraint can't be removed, the CL cut needs to be tightened.

Right now the skim size is unusably large.

I had meant to change this in the past, but not sure the change made it in.

Matt

On Nov 6, 2017, at 11:26 PM, Shepherd, Matthew mashephe@indiana.edu wrote:

Thanks - can you remove the pi0 mass constraint and set the CL cut at 5%? This is tight but necessary.

This message was sent from my iPhone.

On Nov 6, 2017, at 10:57 AM, Paul Mattione notifications@github.com wrote:

It assumed that it was the FIRST analysis channel that was run, and checking that channel to make the skim. So if it was p2pi_hists instead, it instead saved events that passed the RHO cuts. This is fixed now.

Also, it crashed on events that weren't a physics trigger. This is fixed now.

You can view, comment on, or merge this pull request online at:

https://github.com/JeffersonLab/sim-recon/pull/955

Commit Summary

• omega_skim plugin was flat-out broken prior to this. File Changes

• M src/libraries/ANALYSIS/DEventWriterROOT.cc (4) • M src/plugins/Utilities/omega_skim/JEventProcessor_OmegaSkim.cc (34) Patch Links:

• https://github.com/JeffersonLab/sim-recon/pull/955.patch • https://github.com/JeffersonLab/sim-recon/pull/955.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.