Exclusive pi0 skim update - Githubissues

JeffersonLab / sim-recon

Simulation and Reconstruction for GlueX

9 stars 14 forks source link

Exclusive pi0 skim update #960

Closed sdobbs closed 7 years ago

sdobbs commented 7 years ago

update plugin for new analysis library
only write out the showers and vertex information, since that's what is needed for the calibration note that we write out one "event" per combo... but having multiple combos that pass the kinematic fitter in this case should be pretty rare

gluex commented 7 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/tests/log

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/make_sdobbs_excl_pi0_plugin.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/report_sdobbs_excl_pi0_plugin.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin

pmattjlab commented 7 years ago

This plugin is just as broken as the omega_skim plugin was. See the comments on that pull request and please fix it.

sdobbs commented 7 years ago

Is the problem the pi0 constraint business?

aaust commented 7 years ago

No, it is the line where you check the analysisResultsVector[0]. This probes the first reaction in line, which is not necessarily yours.

sdobbs commented 7 years ago

Thanks for the reminder, I was trying to remember which PR fixed the problem...

gluex commented 7 years ago

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/make_sdobbs_excl_pi0_plugin.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/report_sdobbs_excl_pi0_plugin.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin

sdobbs commented 7 years ago

One test got interrupted, there is currently one running

gluex commented 7 years ago

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/tests/summary.txt Logs: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/tests/log

Build log: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/make_sdobbs_excl_pi0_plugin.log Build report: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin/report_sdobbs_excl_pi0_plugin.txt Location of build: /work/halld/pull_request_test/sim-recon^sdobbs_excl_pi0_plugin