JeffersonLab / smoothness

Web application template based on JQuery UI Smoothness theme
https://ace.jlab.org/smoothness-demo
MIT License
0 stars 0 forks source link

Make environment variables consistent #5

Closed slominskir closed 1 year ago

slominskir commented 1 year ago

Currently the PROXY_SERVER env is just the hostname and port of the front URL for the app, but it should probably include the protocol/scheme (probably always https) to be consistent with environment variables such as PUPPET_SHOW_SERVER_URL, KEYCLOAK_SERVER_URL, and INTERNAL_SERVER_URL. Since port is often tied to protocol it really doesn't make sense to specify port but not protocol. Should probably be renamed to include _URL suffix for consistency as well. Might want to rename to FRONTEND_SERVER_URL (and perhaps rename INTERNAL_SERVER_URL to BACKEND_SERVER_URL).

We need to update KEYCLOAK_SERVER_FRONTEND env as well to expect protocol and have _URL suffix. Perhaps rename to KEYCLOAK_FRONTEND_SERVER_URL. Ditto LOGBOOK_SERVER.