search

JeffersonLab / srm

System readiness manager app
https://ace.jlab.org/srm
MIT License
0 stars 0 forks source link

Branch Admin Requires Code Change #3

Open slominskir opened 5 months ago

slominskir commented 5 months ago

Ideally assignment of a new branch admin role could be done completely without having to change the code. A new table could be created for this purpose, for example. See:

https://github.com/JeffersonLab/srm/blob/25852c368869e52d40a9ebf84bf7279a6cf8b85c/src/main/java/org/jlab/srm/business/session/AbstractFacade.java#L216-L252

Issue moved from Jira

slominskir commented 1 month ago

You also can't add a category directly as a child of the root at the moment from the Setup tab (you can't select JLAB directly at the moment). This means you must either insert Category using backend developer database connection or else add it to wrong location first and then move it using backend developer database connection to be child of JLAB (root).

slominskir commented 1 month ago

Also requires code change here:

https://github.com/JeffersonLab/srm/blob/92d76216624591fb572bfafa6f1bd23a1f58e1ae/src/main/webapp/WEB-INF/tags/page.tag#L48

And here:

https://github.com/JeffersonLab/srm/blob/92d76216624591fb572bfafa6f1bd23a1f58e1ae/src/main/webapp/WEB-INF/web.xml#L82

And here:

https://github.com/JeffersonLab/srm/blob/92d76216624591fb572bfafa6f1bd23a1f58e1ae/src/main/webapp/WEB-INF/web.xml#L106-L108

The last two are for declarative security and require either a code change or making a parent role such as "srm-branch-adm" in which all other roles are members of and having that global role be defined in the declarative way.