JeffinsonDarmawan / pe

0 stars 0 forks source link

Duplicated "invalid" output #3

Open JeffinsonDarmawan opened 2 months ago

JeffinsonDarmawan commented 2 months ago

image.png

"invalid" is written twice

nus-se-script commented 2 months ago

Team's Response

Please improve your vocabulary!

invalid1 /ˈɪnvəlɪd/ noun a person made weak or disabled by illness or injury

verb remove (someone) from active service in the armed forces because of injury or illness. "he was badly wounded and invalided out of the infantry"

adjective (of an official document or procedure) not legally recognized because it contravenes a regulation or law. "the will was declared invalid and the children were entitled to the estate"

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: My original argument: "invalid" is written twice, and this is wrong because it is supposed to only be written once, i.e. "Your move is invalid."

Dev's response: "Please improve your vocabulary! ... "

My response to Dev's response:

By taking the dev's own words, I assume that what the response of the developer of this programme means is that the first instance of "invalid" is an adjective that describes my input to be " not legally recognized because it contravenes a regulation or law", and that the second instance of "invalid" describes the user/player as a "a person made weak or disabled by illness or injury". Thus, "invalid" is not incorrectly written twice, because the first one is an adjective and the second one is a noun.

However, I would maintain that this is still a functionality bug of a very low severity level. My reasoning is twofold:

1. Error Message does not Match the Error

It is true that the input is invalid, because I have typed in "a" which is not a number between 1 to 9.

However, it is false that a user therefore becomes an "invalid" (the second "invalid" that is a noun in "Your move is invalid, invalid") because when a user inputs an invalid input, the user/player does not become "a person made weak or disabled by illness or injury". The user does not become an invalid in the context of the game because a wrong input would not make users lose points or lose the game. The state of the game will remain the same and the users would not have lost anything because the user has typed an invalid input. Thus, in the context of the game, typing an invalid input does not result in the user becoming an invalid, i.e. "a person made weak or disabled by illness or injury". However, if what the developer means is that the users become an invalid in the real sense, then I believe this is also blatantly false.

Thus, in accordance with the 3rd point of this screenshot, I believe that this is still a functionality bug of a very low severity level.

image.png

2. Intention not matched with the final consequence

The developers might have the intention of typing two "invalid" to convey two different meanings, i.e. that the input is incorrect and that the user is "a person made weak or disabled by illness or injury".

However, I believe that it is the responsibility of a good programmer to make sure that one's intention is aligned with the final consequence and not assume that everyone has knowledge of the english vocabulary that is as excellent as the developer. Anyone who is playing this tic tac toe game might not have a good enough vocabulary and innocently view two instances of "invalid" as an incorrect error message. After all, this is not an english language game and there is no mention of any users who are proficient in the english language in the User Stories and the Target User Profile section:

image.png

image.png

Thus, I would suggest that if the developers would like to call the user an invalid, perhaps the users can use a synonym which would not confuse the users.

Lastly, the developers of this game might respond by arguing that it is the intended personality of the game where users would be called derogatory terms. However, if that is the case, I would even argue for a higher severity level, because it is not within the user guide that users would be called a derogatory remark. In fact, one of the users shown in the User Stories is a child. I would highly doubt that a child is an appropriate user to play this game.