JeffreyCA / Apollo-ImprovedCustomApi

Use your own Reddit and Imgur API credentials in Apollo
352 stars 18 forks source link

Apollo Ultra features not working #1

Open cameronwilliams opened 11 months ago

cameronwilliams commented 11 months ago

For Apollo 1.15.11, all Apollo Ultra features should be unlocked, but they’re not working.

JeffreyCA commented 11 months ago

Yes this is a known issue, any contributions/suggestions are welcome

JeffreyCA commented 11 months ago

Some findings:

Feature NSUserDefaults standardUserDefaults key Value Notes
Subreddit weather ShowSubredditWeatherTime YES/NO Doesn't work even if set to YES - due to missing WeatherKit entitlements or something else?
New comment highlight ShowUnreadComments YES/NO New comments aren't highlighted when set to YES
Proaxel commented 11 months ago

I heard apps installed with Trollstore still have working entitlements, could Subreddit weather still work that way? I do have a Trollstore compatible device to test with, but it's pretty old at this point (iPhone 7 Plus on iOS 14.5). Either way, that's a bummer how it turned out to require those.

As for New Comments, perhaps there's some other thing that needs to be fulfilled...?

cameronwilliams commented 11 months ago

I don’t think it’s just entitlements. 1.15.11 should have all ultra features unlocked, but even the Pixel Pals don’t work.

JeffreyCA commented 11 months ago

I heard apps installed with Trollstore still have working entitlements, could Subreddit weather still work that way? I do have a Trollstore compatible device to test with, but it's pretty old at this point (iPhone 7 Plus on iOS 14.5). Either way, that's a bummer how it turned out to require those.

As for New Comments, perhaps there's some other thing that needs to be fulfilled...?

I added some working toggles for New Comments Highlightifier and Subreddit Weather under the Custom API settings in this experimental build. Could you give it a test?

For me (without Trollstore), the weather widget never loads and while I do see the new comment badge count on posts, new comments aren't being highlighted.

thexYeti commented 11 months ago

just letting you know that the new comment highlighter works reliably on the outside thread, but doesn’t highlight the actual comment inside the thread. i think it’s supposed to do that, right?

iphone 12 pro, iOS 17 with trollstore IMG_5235 , apollo 1.15.11

Proaxel commented 11 months ago

I forgot, the device I mentioned earlier is also jailbroken so I can just install the deb and not need to mess with sideloading.

But as it turns out I apparently can’t use the tweak at all on it because it requires iOS 15 or newer… is there anything that can be done about this?

IMG_4168

JeffreyCA commented 11 months ago

I forgot, the device I mentioned earlier is also jailbroken so I can just install the deb and not need to mess with sideloading.

But as it turns out I apparently can’t use the tweak at all on it because it requires iOS 15 or newer… is there anything that can be done about this?

IMG_4168

Can you try 1.0.6b? I lowered the iOS version requirement

Proaxel commented 11 months ago

Okay I installed it with Zebra but it doesn't seem to be injecting at all. I didn't get the green popup that you usually see when you first boot the app with the tweak and I don't see the Custom API button on the top right of the General settings screen.

Actually I just realized... since this phone is on an old iOS version, the latest version of Apollo it can use is 1.14.26. Christian apparently dropped iOS 14.x support after that. Did these features even exist on this version? Compared with my main phone, I see neither of them in the settings menu... so that's probably a no.

Shoot, my bad, I should have realized this sooner.

JeffreyCA commented 11 months ago

just letting you know that the new comment highlighter works reliably on the outside thread, but doesn’t highlight the actual comment inside the thread. i think it’s supposed to do that, right?

iphone 12 pro, iOS 17 with trollstore IMG_5235 , apollo 1.15.11

Oh I thought it was supposed to highlight inside the thread as well, see this screenshot I found:

Does the Subreddit Weather feature work for you? It needs the com.apple.developer.weatherkit entitlement I believe.

thexYeti commented 11 months ago

Does the Subreddit Weather feature work for you? It needs the com.apple.developer.weatherkit entitlement I believe.

apologies for the late reply @JeffreyCA

The subreddit weather appears to be not working, i checked a few big cities‘ subreddits. It does have the entitlement com.apple.developer.weatherkit, i included a screen for more info (sourced with appindex)

regarding the new comment highlighter screen you included, i did some more testing and it appears to be not working within the thread (like in the screen), only on the outside, whether in dark or light mode.

I’m happy to help with testing, though i only have this device. (12 pro on ios 17.0 with trollstore, currently using apollo 1.15.11)

cheers and thanks

IMG_5245 IMG_5246

JeffreyCA commented 11 months ago

Thanks for confirming! So don't see a loading spinner like the following or after toggling off and on?

For reference this is what I get:

image

thexYeti commented 10 months ago

no i dont, tested toggling on/off a few times, also tested the new 1.0.7exp version. not that i personally think the sub weather is a very important feature lol. if you need logs or anything, let me know

Fofer commented 10 months ago

I don’t think it’s just entitlements. 1.15.11 should have all ultra features unlocked, but even the Pixel Pals don’t work.

Interestingly enough, the Cat, Dog, and Artificial Superintelligence Pixel Pals work for me. It's only when trying to select any of the other Pixel Pals (Hedgehog, Axolotl, Fox, Otter, etc.) that the app crashes immediately. This is by no means a big deal, I don't really care for Pixel Pals anyway, just sharing what I discovered when tapping around out of curiosity. I am so, so happy that Apollo is resurrected on my iPhone!

cameronwilliams commented 10 months ago

I don’t think it’s just entitlements. 1.15.11 should have all ultra features unlocked, but even the Pixel Pals don’t work.

Interestingly enough, the Cat, Dog, and Artificial Superintelligence Pixel Pals work for me. It's only when trying to select any of the other Pixel Pals (Hedgehog, Axolotl, Fox, Otter, etc.) that the app crashes immediately. This is by no means a big deal, I don't really care for Pixel Pals anyway, just sharing what I discovered when tapping around out of curiosity. I am so, so happy that Apollo is resurrected on my iPhone!

The Cat and Dog work because they’re free. The rest are Ultra features and don’t work. I believe the issue is caused by it thinking it’s the TestFlight version. For the regular version, they’re unlocked, for the TestFlight version, they’re unlockable for free, but only with the IAP entitlement.

Fofer commented 10 months ago

The Cat and Dog work because they’re free.

Understood, thanks. Just saying though that the “Artificial Superintelligence” Pixel Pal (which was not free, was also part of Ultra) works as well.

EDIT TO ADD: changing to any one of the Ultra app icons is working for me too.

samuelawachie commented 10 months ago

Thanks for this; it’s very impressive. Is there any timeline for the new comments highlighter to show inside posts? That’s the only thing left to make this total perfection imo. I know devs don’t like when people ask for ETA but is it being worked on?

JeffreyCA commented 10 months ago

Thanks for this; it’s very impressive. Is there any timeline for the new comments highlighter to show inside posts? That’s the only thing left to make this total perfection imo. I know devs don’t like when people ask for ETA but is it being worked on?

Unfortunately not... if anyone has ideas on how to fix please comment or submit a PR

samuelawachie commented 9 months ago

Thanks for this; it’s very impressive. Is there any timeline for the new comments highlighter to show inside posts? That’s the only thing left to make this total perfection imo. I know devs don’t like when people ask for ETA but is it being worked on?

Unfortunately not... if anyone has ideas on how to fix please comment or submit a PR

The thing is, links in comments threads that point to another comment in a comment thread work. When tapped, it takes you to the comment thread reference and highlights the comment that was linked, with the entire comment thread still there as context. I would’ve assumed the code to fix this would be something similar where it opens the context, and highlights new rather than linked comment. Or it could sort by new and then highlights the comments filtered out by date just using the code for linked comments to display. The reason I say this is that those linked comments work so similarly and look identical to the behavior we wish to implement.

Edit: https://old.reddit.com/r/apolloapp/comments/16h0d5w/did_they_just_deadname_apollo/k0blcx8 Just to add an example of a linked comment that references a target. It opens the thread as context, highlights the link as target, and shows it with a different fill color. So in this case, we’d want to open the thread as context, highlight targets (filtered by new using date, which already exists with the new sort), then display with fill color the way links do theirs. I could be simplifying it but isn’t that basically it?

deeerooo commented 9 months ago

I don’t think it’s just entitlements. 1.15.11 should have all ultra features unlocked, but even the Pixel Pals don’t work.

Interestingly enough, the Cat, Dog, and Artificial Superintelligence Pixel Pals work for me. It's only when trying to select any of the other Pixel Pals (Hedgehog, Axolotl, Fox, Otter, etc.) that the app crashes immediately. This is by no means a big deal, I don't really care for Pixel Pals anyway, just sharing what I discovered when tapping around out of curiosity. I am so, so happy that Apollo is resurrected on my iPhone!

I just happened to be messing around with preferences in Filza, and if you have access, you can change to any pixel pal.

It's in group.com.christianselig.Apollo.plist,

"ActivePixelPal" . Just use the lower case version of the pal, like "panda" etc. Don't really care for them either but cool to have back!

Also works for adding and removing filters/subreddit filters, which was also crashing on my TrollStore installation.

JeffreyCA commented 3 months ago

Thanks for your patience everyone, a working version of New Comments Highlighter is now available in v1.1.1 (#32)!

Please report any issues/bugs you encounter - I had to make a semi-custom implementation so it may not behave exactly as the original one.

samuelawachie commented 3 months ago

Thanks for your patience everyone, a working version of New Comments Highlighter is now available in v1.1.1 (#32)!

Please report any issues/bugs you encounter - I had to make a semi-custom implementation so it may not behave exactly as the original one.

Way to go mate! Well done! I'm using it now and it's working beautifully so far. What's the FLEX option really? Is it for debugging the app? I know I was nearly a nuisance asking for this feature, but umm I'm so glad it's here now.

JeffreyCA commented 3 months ago

Yes FLEX is for debugging (more info here). It's usually used in tweaks for other apps as well

thexYeti commented 3 months ago

Works really well now, props for making it work and thanks!