JeffreyCA / Apollo-ImprovedCustomApi

Use your own Reddit and Imgur API credentials in Apollo
365 stars 19 forks source link

Share link support #4

Closed JeffreyCA closed 10 months ago

JeffreyCA commented 11 months ago

From https://github.com/EthanArbuckle/Apollo-CustomApiCredentials/issues/36:

Recently Reddit started implementing a new format for share URLs on their mobile apps. This is not supported by Apollo.

how it breaks Apollo When a user clicks on one of these links, instead of being pushed to the post or comment in question, a WebView opens. This page is often broken if the share link is to another comment, or NSFW post.

Example:

  1. shortlinks https://redd.it/1641krf redirects to https://www.reddit.com/r/ModSupport/comments/1641krf/reddit_broke_the_report_forms_by_now_using_a/
  2. mobile sharelinks https://reddit.com/r/ModSupport/s/9aRRC2rZpd redirects to https://www.reddit.com/r/ModSupport/comments/1641krf/reddit_broke_the_report_forms_by_now_using_a/?share_id=HXzTX3cWsSnrFxIy1IsDg (includes trackable share_id)

Current bugs:

JeffreyCA commented 11 months ago

@losh11, just added support for share links in v1.0.4! Took quite a bit of trial and error and I might've over-engineered some parts of it but it functions nicely for the most part.

There are currently a few limitations:

Please let me know if you run into any issues with it.

JeffreyCA commented 10 months ago

Closing for now, minor bugs remain: