search

JeffreyJPZ / ubc-classrooms

A tool that finds classroom availabilities across UBC.
MIT License
1 stars 1 forks source link

Add latitude and longitude to Building model #20

Closed supercoder-dev closed 3 months ago

supercoder-dev commented 3 months ago

Added latitude and longitude fields to the Building model. This lays the groundwork for displaying classroom locations on a map (issue #11). A migration will be needed for this change.

JeffreyJPZ commented 3 months ago

Hey, thanks for the PR, will review this once I have some more time.

JeffreyJPZ commented 3 months ago

Hey @supercoder-dev, thanks again for the PR.

After some thought, I think its best to avoid making unnecessary changes to the model, as we would also need to update the serializers and views.

If you'd like, I think blucardin's comment is a good step in the right direction, incorporating UBC's existing website. Since it looks like CORS requests aren't allowed, I'd suggest setting up a proxy using nginx, making requests for buildings/room pages through the proxy, and maybe embedding the response in an iframe. You can find the nginx config file in the nginx/conf folder.

If you have any questions, feel free to reply below.