search

JeffreyWay / Laravel-4-Generators

Rapidly speed up your Laravel workflow with generators
https://packagist.org/packages/way/generators
MIT License
27 stars 9 forks source link

replacing tabs by 4 spaces - PSR-2 #429

Closed ghost closed 9 years ago

ghost commented 9 years ago

With reference to PHP PSR-2 ( https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md ) code must use 4 spaces for indenting, not tabs.

chrapek commented 9 years ago

+1

vladshcherbin commented 9 years ago

@BlueManLine 4 spaces are shit. hope, they won't be used in laravel or it packages.

rrozanka commented 9 years ago

@VladShcherbin its a standard to use 4 spaces instead of tabs, I don' t get whats wrong with that?

+1

ghost commented 9 years ago

PSR-2 is a standard, not option! Tab in every editor look different, space not.

vladshcherbin commented 9 years ago

They are super uncomfortable to use. Laravel does not use them which is SUPER cool. And it is not the first attempt to bring them to Laravel, if I remember correctly.

m4r3x commented 9 years ago

+2

andrewhood125 commented 9 years ago

This is something that has bothered me a bit so I'm a big :+1: here.

mikeerickson commented 9 years ago

+1

18601673727 commented 9 years ago

+1

ghost commented 9 years ago

How about that - https://github.com/laravel/framework/commit/c0824c5d2acb46d35125062fa28a76fd0b29feac

mikeerickson commented 9 years ago

I am guessing we will not see this anytime soon as Jeffrey has made it pretty clear he has no desires to maintain Generators moving forward.

Guess it is time to fork and see if this is something worthwhile maintaining into future.

JeffreyWay commented 9 years ago

L5 is PSR-2, not L4.