Jellayy / ez.gg

Ultimate League of Legends Companion App based on Python and HTML through eel
6 stars 3 forks source link

Unable to automatically accept matchups #32

Open LianhaoXue opened 2 years ago

LianhaoXue commented 2 years ago

PZ@Z 2X%HVS% )I7Z~66TU0 /lol-matchmaking/v1/ready-check/accept --> This API should use the HTTP2 protocol

musicderp commented 2 years ago

Could I get your full logs as well as the region you're on? If http2 is actually what's needed to make these calls, it will require a massive rewrite of willump, as that is what handles talking to the LCU and I don't think aiohttp supports this.

LianhaoXue commented 2 years ago

Thanks for your reply.I live in China. I've found some people to be successful with HTTP2, for example, https://github.com/clearsky/LCU_API and https://github.com/real-web-world/hh-lol-prophet. I tried to rewrite Willump using the HTTPX library, but I failed.

------------------ 原始邮件 ------------------ 发件人: "Jellayy/ez.gg" @.>; 发送时间: 2022年4月23日(星期六) 中午12:32 @.>; @.**@.>; 主题: Re: [Jellayy/ez.gg] Unable to automatically accept matchups (Issue #32)

Could I get your full logs as well as the region you're on? If http2 is actually what's needed to make these calls, it will require a massive rewrite of willump, as that is what handles talking to the LCU and I don't think aiohttp supports this.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

LianhaoXue commented 2 years ago

image This is logs.

Jellayy commented 2 years ago

Honestly something I never thought to test for. I wonder how many other regions are on HTTP2 or if it's localized to China. I assume much like us, Willump was only tested in NA.

If you're interested in rewriting a version for HTTP2, eventually we want to move away from Willump entirely and that might make it easier when that happens. It was great to use while still figuring out how the LCU API worked, but it does some things really weird and we want to move to either using lcu-driver or interfacing with the LCU API exclusively on our own.