search

JelleAalbers / blueice

Build Likelihoods Using Efficient Interpolations and monte-Carlo generated Events
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

Add compute_pdf to LogLikelihoodSum.__call__ #22

Closed pelssers closed 6 years ago

pelssers commented 6 years ago

I propose to add compute_pdf to the LogLikelihoodSum call. This way pdfs can be recomputed for each of the likelihoods in a likelihood sum (needed in case of analytical pdfs). This also makes it behave the same way as the LogLikelihoodBase call.

JelleAalbers commented 6 years ago

Sounds good! I suppose in some cases you want to combine analytic and numerical sources without recomputing the latter, but we can think about that when it comes up. @kdund, any comments?

pelssers commented 6 years ago

Thanks, ideally we could put this option also in the config where we could also specify which sources have analytical pdfs and need to be recomputed, but I'm not sure how at the moment. In either case I think it is good to have compute_pdf in the call for consistency. Before it got silently absorbed by the kwargs and left me wondering why the pdfs werent computed :)

pelssers commented 6 years ago

Travis builds were failing because of some conflict with a system package. Now conda installs the python packages inside the travis_env environment and runs all the tests from there. So Travis is building again, now we need to look at the coveralls coverage :)

JelleAalbers commented 6 years ago

Nice work Bart! With the tests succeeding I'm sure it's fine to merge.