JelleAalbers / blueice

Build Likelihoods Using Efficient Interpolations and monte-Carlo generated Events
BSD 3-Clause "New" or "Revised" License
9 stars 9 forks source link

Pass more settings to minuit in bestfit_minuit #25

Closed JelleAalbers closed 5 years ago

JelleAalbers commented 5 years ago

According to https://github.com/JelleAalbers/blueice/blob/master/blueice/inference.py#L206, our minuit implementation does not yet account for bounds. That's probably OK, since the likelihood function just gives -float('inf') outside physical bounds, but maybe minuit would appreciate (and perhaps be more reliable) if we tell it our bounds more gently.

If we're planning to use or report the errors from minuit at some point, we should also set the error_def parameter to 0.5. According to https://nbviewer.jupyter.org/github/iminuit/iminuit/blob/master/tutorial/basic_tutorial.ipynb this sets up the right magic for negative log likelihood functions.