search

JelleZijlstra / lxml-stubs

Obsolete, please use https://github.com/lxml/lxml-stubs
Other
12 stars 3 forks source link

Various additions #3

Closed funkyfuture closed 5 years ago

funkyfuture commented 5 years ago

i'm absolutely not sure whether i approached the XMLParser's target argument type correctly. i don't know if it can be addressed at the moment at all, as there is not class provided by lxml that would be used as base for such classes.

funkyfuture commented 5 years ago

i just noticed that there is typing_extensions that could be used for structural typing. @JelleZijlstra would it be feasible to add this as dependency?

JelleZijlstra commented 5 years ago

Yes, it's fine to use Protocol in stubs; the dependency doesn't even have to be declared.

zadamah commented 5 years ago

Hello, First, thank you @JelleZijlstra for starting and sharing this project. I was intending to add some type annotations that I needed such as XMLParser. That's how I landed here, seeing that @funkyfuture already did that and then more, thank you :raised_hands:. So, I was just wondering if you will merging these changes soon. Also, I would be very happy to contribute if any help is needed.

JelleZijlstra commented 5 years ago

I'd be OK with merging but there is a merge conflict. @funkyfuture could you fix it? Thanks for contributing these stubs!

funkyfuture commented 5 years ago

done.

funkyfuture commented 5 years ago

@JelleZijlstra is there anything i can do to get this going?