search

JelleZijlstra / stubdefaulter

Add default values to stubs
Other
10 stars 4 forks source link

Fix packaging to include all project files #61

Closed hamdanal closed 1 year ago

hamdanal commented 1 year ago

Closes #60

Now that multiple files have to be included, I made it into a package so that all files are installed under the namespace of the project.

hamdanal commented 1 year ago

What's packaged:

sdist:

$ tar -tf dist/stubdefaulter-0.0.0.tar.gz
stubdefaulter-0.0.0/stubdefaulter/__init__.py
stubdefaulter-0.0.0/stubdefaulter/__main__.py
stubdefaulter-0.0.0/stubdefaulter/stdlib-blacklist.txt
stubdefaulter-0.0.0/.gitignore
stubdefaulter-0.0.0/pyproject.toml
stubdefaulter-0.0.0/PKG-INFO

wheel

$ unzip -l dist/stubdefaulter-0.0.0-py3-none-any.whl
.whl
Archive:  dist/stubdefaulter-0.0.0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
    22244  2020-02-02 00:00   stubdefaulter/__init__.py
       70  2020-02-02 00:00   stubdefaulter/__main__.py
     2070  2020-02-02 00:00   stubdefaulter/stdlib-blacklist.txt
      718  2020-02-02 00:00   stubdefaulter-0.0.0.dist-info/METADATA
       87  2020-02-02 00:00   stubdefaulter-0.0.0.dist-info/WHEEL
       53  2020-02-02 00:00   stubdefaulter-0.0.0.dist-info/entry_points.txt
      578  2020-02-02 00:00   stubdefaulter-0.0.0.dist-info/RECORD
---------                     -------
    25820                     7 files
JelleZijlstra commented 1 year ago

Seems like you need to change the pyanalyze test to run on stubdefaulter/ instead of stubdefaulter.py.

github-actions[bot] commented 1 year ago

This change has no effect on how stubdefaulter would alter typeshed's stdlib. 🤖🎉

hamdanal commented 1 year ago

BTW would you consider adding a license? I just realized the project doesn't have any. Technically it cannot be used by others.

JelleZijlstra commented 1 year ago

Good point, I'll add a license. Would it also be useful to you if I publish on PyPI?

github-actions[bot] commented 1 year ago

This change has no effect on how stubdefaulter would alter typeshed's stdlib. 🤖🎉

hamdanal commented 1 year ago

Good point, I'll add a license. Would it also be useful to you if I publish on PyPI?

It would save me some key strokes when I pip install but do not bother if you don't want to, not a big deal. I only tried it once with some stubs I keep around for a better vscode experience (unsuccessfully for now but I haven't spent more than 5 minutes on it yet).

Thank you for creating this btw, it helps a lot with editors that rely on typeshed for showing function and class signatures.