search

JellevanCampen / pugvania

The Pugvania project contains the implementation of a 2D game and its engine. The poject contains two subprojects: (1) Engine - a static library project containing engine code, and (2) Game - an executable project containing game code.
MIT License
0 stars 0 forks source link

Verify whether explicitely including the headers for the Game and Engine projects is required #2

Closed JellevanCampen closed 8 years ago

JellevanCampen commented 8 years ago

Verify whether the following lines are explicitely required in the CMakeLists.txt file for the Game project: 

# Make Game's includes available
target_include_directories (game PUBLIC CMAKE_CURRENT_SOURCE_DIR)

Verify whether the following lines are explicitely required in the CMakeLists.txt file for the Engine project: 

# Make Engine's includes available
target_include_directories (engine PUBLIC CMAKE_CURRENT_SOURCE_DIR)

It is possible that the includes in the actual project directory are available by default without explicitely adding them as an include directory.

JellevanCampen commented 8 years ago

Explicitely specifying include directories is only required for includes that are not part of the current target. I.e. the Engine target will automatically include its own source directory, and the Game target will automaticallz include its own source directory.

In short: the above lines have been removed.