Jellycuts / Jellycuts-Issues

A public issue tracker for the Jellycuts iOS app.
23 stars 0 forks source link

"Done" instead of "Dismiss" for modal views #38

Closed colin273 closed 3 years ago

colin273 commented 3 years ago

Is your feature request related to a problem? Please describe.

It's a bit confusing to me to see "Dismiss" in the upper right hand corner as the button to dismiss modal views. It's inconsistent with other apps.

Describe the solution you'd like

Change the text of the modal view dismissal button throughout the app from "Dismiss" to "Done."

Additional context

Pardon me if this sounds like preach Apple interface guidelines, but "Done" is preferable to "Dismiss" because it suggests the user is done with the content in the view and puts the focus on the content, rather than dismissing the view. The app itself should get out of the way of the content.

ActuallyTaylor commented 3 years ago

Fixed this