search

Jellyfish-Insights / andromeda

Don’t be held hostage by other providers. Own and aggregate your data from organic and paid campaigns in a single place to pull and review as needed
http://jellyfishinsights.com/
Apache License 2.0
11 stars 5 forks source link

Migrate functions doesn't handle exceptions #60

Closed lucaslovato closed 2 years ago

lucaslovato commented 4 years ago

Describe the bug 🐛

Verifications are always needed on the project, with this on the file MigrateCommand.cs when the program calls the functions and after them the project is just printing success so a verification for exceptions on this functions is requested.

To Reproduce 😯

  1. Go to andromeda/Andromeda.ConsoleApp/Commands/MigrateCommand.cs
  2. Scroll down to lines 31 and 39
  3. See that functions MigrateDataLake() and MigrateFacebook() doesn't handle exceptions

Expected behavior 🤔

We expect that database functions are prepared to handle exceptions.

Your environment

moraesvic commented 2 years ago

Closing because the project context changed too much since then