Some favorites doesn't have icons nor names

[ByJumperX4]

Checklist

• [x] I searched the :help documentation using / for helpful information
• [x] I have read the frequently asked questions
• [x] I did not find any similar issues in the issue tracker

Describe the bug Some websites won't have icons nor names when added to favorites

To Reproduce Add some favorites, and find some websites that won't work

Expected behavior Every favorite should have an icon and a name

Specs

• OS: Funtoo w/ dwm
• Version: latest master compiled from source

[Jelmerro]

This is likely because you haven't visited these pages yet. Fetching the correct favicon and title require a connection to the page to be made, which Vieb will NOT do when you add favoritepages. One of Vieb's core aspects is privacy, which also comes with a handful of drawbacks. The favicons are cached, so you only need to visit them once, but it won't automatically connect to sites just because you updated some local setting. The same is true for other settings and most other features. The only notable exception is when you ask Vieb to automatically update the adblocker lists, that can only be done by making a request, for which Vieb will always show a notification when this happens.

Let me know if I was correct to assume you haven't visited these pages or if you think there is a different problem happening.

[ByJumperX4]

I did visited those pages, I visit them all very often. For example, mastodon.online does have an Icon in the tabs list when I open it, but it will never have one in my favourites list

[Jelmerro]

Can you check if the url matches with the one recorded in your history?

[ByJumperX4]

I think it's that, it redirects to something else, like git.gnous.eu that goes to git.gnous.eu/explore/repos

[Jelmerro]

Right, currently there isn't any logic to keep these redirects linked to a favicon, as that url doesn't actually have one. Same for the title. I see two options to handle these type of redirects:

• Assume that redirecting sites have the same title and favicon (this isn't very reliable or correct)
• Only store and match this data for the same urls (current behavior)

If you have any other suggestions, let me know, but these seem to me like the only two options.

[ByJumperX4]

Maybe adding an option like :set favoritepagesreditects true ?

[Jelmerro]

This is not only for favoritepages though, but also for topsites and other places. Besides, a setting like that would only take effect the next time you would visit that page, because it would require storing this as the redirect happens. Speaking of which, I'm not sure how redirects are actually communicated with Electron and if we would need to check only same domain redirects or allow any redirect to have this behavior.

[Jelmerro]

Turns out that there are APIs in electron to catch redirects, I'll update the favicon and page title mappings with them shortly. That should resolve most of this issue, but you'll always need to visit the page at least once to get the favicon as Vieb won't request it in the background.

[Jelmerro]

Let me know if my latest commit fixes this issue for you as well.

[Jelmerro]

Implemented in the latest release 5.1.0 release.