search

Jelmerro / Vieb

Vim Inspired Electron Browser - Vim bindings for the web by design
https://vieb.dev
GNU General Public License v3.0
1.33k stars 65 forks source link

Use vim commands for handling tabs #270

Closed Silur closed 3 years ago

Silur commented 3 years ago

Tabs are not bound to standard vim commands as of now - t, d, w b. It'd be nice to support the standard vim commands for handling tabs: :tabe <file/URL> to open a tab, gT and gt to switch tabs and :q to close a tab.

Silur commented 3 years ago

found out that gT and gt works by default, and for now mapping tabe to openNewTab is a quick solution

Jelmerro commented 3 years ago

gt and gT are already there, I just preferred single character keys for the intro section, as you correctly noted.

Instead of :tabe, there is a separate mode for navigation named Explore mode. This was done because it's such an important part of a web browser, that it made sense to give this more flair and realtime suggestions with colors and icons. Pressing e to navigate is actually in line with a couple of other Vim browser plugins, so I'm luckily not the only project/person thinking this :wink:

The :q command is there. The difference of :q is that Vieb will quit if there are multiple tabs, because tabs in Vieb are more of a browser thing than an actual Vim tab implementation. However, the :q command will close the current split if you are using window splits, similar to Vim. Vieb aims to bring a similar experience to the web, not one that is identical just for the sake of it. I have experimented with making tabs more close the Vim, and each time it felt unnatural to do so in a browser context. This is why I decided to only make splits work identical and let tabs be relatively close to regular browsers. In case you feel that it should be more close to Vim, I encourage and welcome PRs, but for now I will consider this question answered.