search

Jelmerro / Vieb

Vim Inspired Electron Browser - Vim bindings for the web by design
https://vieb.dev
GNU General Public License v3.0
1.29k stars 61 forks source link

Add pageRSSLinkToClipboard to copy RSS feed links to clipboard #480

Closed rafael-xmr closed 1 year ago

rafael-xmr commented 1 year ago

a draft attempt at implementing https://github.com/Jelmerro/Vieb/issues/385#issuecomment-1524067991, probably needs a way to select which feed to copy since this gets the first link tag and some sites can have multiple per page

peek

Jelmerro commented 1 year ago

Thanks for taking the time to implement this! If you could use includes instead of indexOf !== -1, as that is more in line with the rest of the code.

If multiple RRS feed links are common, maybe a separate action list them and copy a single one would be cool, and copy them by index using a mapping like yR1, yR2 etc. and then yRL or yRR that could list them. If it's not that common maybe just the first link copy would be good enough.

rafael-xmr commented 1 year ago

Thanks! what do you think now?

https://github.com/Jelmerro/Vieb/assets/76502841/b4b1851c-c057-462c-bdf3-b2be8fe834f5

Jelmerro commented 1 year ago

That's very good, I like this implementation a lot. Thank you for taking the time to make this feature, it will land in V10 soon.