Jelmerro / Vieb

Vim Inspired Electron Browser - Vim bindings for the web by design
https://vieb.dev
GNU General Public License v3.0
1.32k stars 63 forks source link

Support of WebAuthn / Security Key #483

Closed elquimista closed 1 year ago

elquimista commented 1 year ago

Checklist

Addition or change I like Vieb very much (thank you for all your efforts put into this). However there are a few things that prevent me from using it as my main default browser for now.

I have figured out most of the stuff above (workaround or find it ok to live without) but the last one (security key support) is something I can't compromise. Is there any plan / roadmap to ship this feature?

Jelmerro commented 1 year ago
elquimista commented 1 year ago

@Jelmerro - thanks for your quick response. When I tried a website that is supposed to ask for my yubikey (it does in Chrome and Brave), it never asked for it in Vieb. No notifications, just plain white blank page. But I will check h :notifications in the help page further. Thanks again for your guidance.

Jelmerro commented 1 year ago

Make sure to also check the console tab of the development tools using :devtools or F12, this is where any page errors end up, and where I would expect an error if the permission was indeed denied or the API is somehow not working otherwise.

elquimista commented 1 year ago

I already checked console in the dev tools and there is no error.

elquimista commented 1 year ago

Never mind. I just now realized my yubikey's light is blinking when I am on the login page. It's just not showing the familiar webauthn prompt I used to get in other Chromium browsers. And when I touched my yubikey while it was blinking, login worked!

However, it didn't ask for my PIN code of my yubikey. In other Chromium browsers, they ask for PIN code when I touch my yubikey.

elquimista commented 1 year ago

Let me know if you have any idea about this. Otherwise, I am happy to close this issue for now.

Jelmerro commented 1 year ago

I'm glad it's working for you now too! I think it's just the stripped Electron implementation of the key auth, since there is no chromium UI in Electron by default, they probably figured just having support without the UI was more useful than requiring users to build support for it from scratch. I would expect there to be Electron issues regarding the lack of PIN, but all I can find are issues related to lack of support, but it's supported already...