Jelmerro / Vieb

Vim Inspired Electron Browser - Vim bindings for the web by design
https://vieb.dev
GNU General Public License v3.0
1.29k stars 61 forks source link

`action.nextPage` no longer working on some pages #488

Closed tejing1 closed 1 year ago

tejing1 commented 1 year ago

Checklist

Describe the bug action.nextPage (and of course action.previousPage) no longer work on, for example, royalroad chapter views. These pages use a <link rel="next" href="..."> tag in the header to signal where to find the next page. Vieb 9.7.1 followed these just fine, but Vieb 10.0.0 does not.

To Reproduce

Expected behavior action.nextPage should follow the same links it did before.

Specs

tejing1 commented 1 year ago

If I'm reading the code right, it looks like a sanity check was added to navigateToPage, which required the element to be <a>, thus disallowing <link>.

Jelmerro commented 1 year ago

Fixed in 10.1.0 :tada:

tejing1 commented 1 year ago

Confirmed. Thanks!