Jelmerro / Vieb

Vim Inspired Electron Browser - Vim bindings for the web by design
https://vieb.dev
GNU General Public License v3.0
1.29k stars 61 forks source link

Horizontal navigation problem #498

Closed bogdan-the-great closed 1 year ago

bogdan-the-great commented 1 year ago

Checklist

Describe the bug On sites like Mangadex, and Bato.to (manga readers, where you can click left/right arrow keys to go to the next page), Vieb doesn't scroll pages horizontally, while Qutebrowser and Firefox do. Up/Down arrow keys work just fine.

To Reproduce Try to use left/right arrow keys on these sites.

Expected behavior Pages turn normally as expected.

Jelmerro commented 1 year ago

I don't fully understand the issue, since it lacks steps to reproduce. Is this inside insert mode and do you have an example page where this happens?

bogdan-the-great commented 1 year ago

In normal mode, go to for example Mangadex and try to turn pages. That doesn't seem to work as on the other browsers. I also couldn't find any site that is not center aligned in a way that I could zoom and try to move horizontally, so I don't know if it persists in all sites.

Jelmerro commented 1 year ago

Normal mode arrow keys scroll the page, they don't send keyboard input to the website, if you want this, use insert mode. This strong mode and thus shortcut separation was a big reason for starting Vieb over other mentioned projects, hence why its behavior is unique compared to the mentioned browsers. Basically you are only sending these arrow keys to Vieb, which uses them to scroll the page vertical/horizontal, not to send the keypress to the website, you first need to enter insert mode with i to have your keys send to the page.

bogdan-the-great commented 1 year ago

Insert mode doesn't scroll them either. Still only vertical scroll works.

Jelmerro commented 1 year ago

If I go to insert mode and then use the left and right arrows I get the next/previous pages, is this not what should be happening?

bogdan-the-great commented 1 year ago

Thanks a lot, it started to work as expected! Guess I'm going full time Vieb now.

bogdan-the-great commented 1 year ago

Closing