search

JelteF / derive_more

Some more derive(Trait) options
MIT License
1.73k stars 123 forks source link

Backport Update to Syn 2 #368

Closed bash closed 4 months ago

bash commented 4 months ago

Hi 👋🏼

I'm currently working on reducing duplicate dependencies in @janhohenheim's Bevy game template Foxtrot (relevant PR in Foxtrot). His template is quite representative of the kinds of dependencies that you'll find in Bevy games.

A couple of the dependencies (bevy_xpbd_3d, leafwing-input-manager, ruzstd) depend on derive_more which in turn depends on Syn 1. Most other dependencies have already updated to Syn 2.

I have backported the Syn 1 to 2 update to derive_more v0.99.17 in my fork. Would you be interested in upstreaming my backport and releasing a new patch version?

JelteF commented 4 months ago

Yeah sounds great

bash commented 4 months ago

Yayy, that's good to hear! If you create a branch off the https://github.com/JelteF/derive_more/tree/v0.99.17 tag I can then open a PR targeting that branch :)

JelteF commented 4 months ago

I created the release-0.99 branch for this: https://github.com/JelteF/derive_more/tree/release-0.99

JelteF commented 4 months ago

Okay, I decided I had time now (and maybe not tomorrow). So I did some changes myself to get CI working again (I didn't realize you had done similar changes on your branch). And now I cherry-picked your commit that did all the syn2 migration stuff. And I now published 0.99.18

Thanks a lot for spending time on this!

janhohenheim commented 4 months ago

Thanks for the backport :)