search

Jems22 / fastlane-plugin-increment_version_code

Increment the version code of your android project.
MIT License
170 stars 37 forks source link

Have you planned to manage versionName too ? #11

Open cyrillekrasinski opened 6 years ago

cyrillekrasinski commented 6 years ago

Hi, I've just tested your plugin and the management of flavours is great for our project. Have you planned to upgrade the plugin to add a method to increment the versionName too ? It will be great to be able to update the versionName attribute with patch, minor or major option to increment the version (2.0.0=>2.0.1 for a patch, 2.0.0=>2.1.0 for a minor and 2.0.0 => 3.0.0 for a major).

Another plugin exists to update this version name but it does not support flavour and my issue has not been treated.

engi2nee commented 5 years ago

@cyrillekrasinski may I know how were you able to manage the flavors for it? I can see that there is a field called ext_constant_name that is supposed to help define the flavor. This plugin is missing documentation, can you show an example of your Fastfile and the gradle that uses flavors ?

oklimberg commented 4 years ago

Would you call this plugin manually to set the versionName? Setting the marketing version aka versionName seems to be a task, which only needs to be executes one in a while and not on every build. Do you have a usecase, where this feature would be handy?

And I guess, if I decide to implement this, it might be a standalone plugin.