JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Optimize weapon for characters using sword doesn't work #104

Closed NightmareJxS closed 2 years ago

NightmareJxS commented 2 years ago

Describe the bug When choose a sword using character and use the optimize weapon function, it froze ( or crash ) and cause others damage calculator functions to stop running.

To Reproduce Steps to reproduce the behavior:

  1. Choose a sword using character
  2. Click on optimize weapon with any target setting
  3. Nothing happen but when you trying to use any other functions, it wouldn't run.
  4. See error

Expected behavior A optimized weapon for a specific target (ways of dealing DMG) for sword characters

Screenshots image The damage value doesn't change even when the original value was changed ( maybe it haven't done optimizing weapon )

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context I also test with Chrome on my phone and it still not working.

NightmareJxS commented 2 years ago

It seems like upon releasing Yoimiya and Sayu characters into the damage calculator. The problem had been fixed.

Thanks for the hard-working, keep up the good work!