search

JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Noelle Constellation 4 effect shows 40% ATK instead of 400% ATK #13

Closed Minitte closed 3 years ago

Minitte commented 3 years ago

Describe the bug When viewing Noelle's damage dealt with her 4th constellation, the damage displayed equals 40% of her ATK instead of 400%.

Constellation 4: To Be Cleaned: "When Breastplate ends or shatters, it deals 400% of ATK as Geo DMG to surrounding opponents." -https://genshin-impact.fandom.com/wiki/Noelle

To Reproduce Steps to reproduce the behavior:

  1. Create a slot for Noelle.
  2. Set Noelle's constellation to 4 or higher.
  3. View the damage listed under Noelle's 4th constellation "To Be Cleaned".

Expected behavior The damage calculation should be:

Instead of:

Screenshot noelle 40 400

Desktop (please complete the following information):

Additional context I suck at math so maybe it's wrong. (DMG / (1 + GEO%)) / ATK = Current damage scaling According to screenshot: (46 / (1 + 0)) / 115 = 0.4 (40%)

SiriusGreyhound commented 3 years ago

Hey, thanks for letting us know. We're going to verify it and then fix it if it's really wrong.

SiriusGreyhound commented 3 years ago

"When Breastplate&#39s duration expires or it is destroyed by DMG, it will deal 400% ATK of Geo DMG to surrounding enemies.",calcStats:[{stat:"Expiration DMG",damage:e=>.4,damageType:"ElementalSkillDMG",damageElement:"GeoDMG"}]}; I found the corresponding code and it does indeed have a 0.4 multiplier there. I don't have C4 Noelle, so I can't do any actual tests to compare values between the calculator and in game values.

JenShin-368 commented 3 years ago

Fixed.